Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uberJar parameter from Maven mojos/goals in 1.13 #14878

Closed
5 tasks done
famod opened this issue Feb 6, 2021 · 5 comments · Fixed by #14987
Closed
5 tasks done

Remove uberJar parameter from Maven mojos/goals in 1.13 #14878

famod opened this issue Feb 6, 2021 · 5 comments · Fixed by #14987
Assignees
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/maven
Milestone

Comments

@famod
Copy link
Member

famod commented Feb 6, 2021

Description
As agreed on the mailing list, the uberJar parameter in QuarkusBootstrapMojo (BuildMojo and GenerateCodeMojo respectively) should not be used anymore.
Instead, quarkus.package.type=uber-jar shall be used, as already documented: https://quarkus.io/guides/maven-tooling#uber-jar-maven

Implementation ideas

@famod famod added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Feb 6, 2021
@ghost ghost added the area/maven label Feb 6, 2021
@ghost
Copy link

ghost commented Feb 6, 2021

/cc @quarkusio/devtools

@famod famod added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Feb 6, 2021
@famod famod self-assigned this Feb 6, 2021
@glefloch
Copy link
Member

glefloch commented Feb 7, 2021

@famod we can also set this param in gradle plugin such as gradle quarkusBuild -PuberJar. I guess this should also be removed no? I can handle the gradle part.

@famod
Copy link
Member Author

famod commented Feb 7, 2021

@glefloch I think this makes sense! We first need to deprecate it and log a warning to give users time until it is removed in 1.13.
If all goes to plan I'll create a PR later today for the Maven part. So if you would cover the Gradle part that would be great! Thanks!

@famod
Copy link
Member Author

famod commented Feb 7, 2021

/cc @gsmet @aloubyansky @stuartwdouglas FYI ^ (Gradle part wasn't discussed before)

@famod
Copy link
Member Author

famod commented Feb 7, 2021

@glefloch FYI, #14886 deprecates the mojo parameter and logs a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/maven
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants