Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate uberJar mojo parameter and log a warning when used #14886

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Deprecate uberJar mojo parameter and log a warning when used #14886

merged 1 commit into from
Feb 8, 2021

Conversation

famod
Copy link
Member

@famod famod commented Feb 7, 2021

Relates to #14878.

Notes:

  • I replaced the remaining usages with Maven properties, not with application properties, because I prefer to keep build related stuff out of application.properties/.yaml, but I have no hard feelings if you want it the other way.
  • I stole the pattern for the warning from here: Log warning about the use of NativeImageMojo #14634

@ghost ghost added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/maven labels Feb 7, 2021
@famod
Copy link
Member Author

famod commented Feb 7, 2021

Not entirely sure about backporting but since #14634 was also backported (to 1.11.1), I think the earlier users are warned the better.

@gsmet gsmet merged commit 3af53cc into quarkusio:master Feb 8, 2021
@ghost ghost added this to the 1.12 - master milestone Feb 8, 2021
@famod famod deleted the uberJar branch February 8, 2021 09:56
@gsmet gsmet modified the milestones: 1.12 - master, 1.11.2.Final Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants