Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grpc netty keep-alive-time configuration option #14957

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Add grpc netty keep-alive-time configuration option #14957

merged 1 commit into from
Feb 12, 2021
+37 −0

Conversation

michalszynkiewicz
Copy link
Member

@ghost ghost added the area/grpc gRPC label Feb 10, 2021
@michalszynkiewicz
Copy link
Member Author

@cescoffier I rebased the changes. I looked at grpc-java and vertx-grpc code and they don't have tests for keep-alive too...

gsmet
gsmet previously requested changes Feb 10, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require a squash.

@michalszynkiewicz michalszynkiewicz force-pushed the spoud/feat/grpc-netty-keep-alive-time branch from 046daca to 619dae7 Compare February 10, 2021 14:15
@michalszynkiewicz
Copy link
Member Author

@gsmet done

@gsmet gsmet merged commit 81b9cd2 into quarkusio:master Feb 12, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 12, 2021
@michalszynkiewicz michalszynkiewicz mentioned this pull request Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@gsmet gsmet gsmet left review comments

Assignees
No one assigned
Labels
area/grpc gRPC
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@michalszynkiewicz @cescoffier @gsmet @spike83