-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc netty keep-alive-time configuration option #12415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Added a small comment but I'll let @michalszynkiewicz and @cescoffier handle this one.
...sions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/config/GrpcServerConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test?
extensions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/config/GrpcServerNettyConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Clement Escoffier <[email protected]>
@cescoffier Sure, what kind of test would you expect. You may point me to some similar tests? |
extensions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/config/GrpcServerNettyConfig.java
Show resolved
Hide resolved
I can't speak for Clement but I think the following would be good to test:
I think it would be okay to add the tests to |
@michalszynkiewicz what should we do with this PR? |
I just came back from PTO, I added creating a test for it to my todo list. |
Unfortunately this went out of my focus. Sorry for that. I was looking into testing a while ago and had no clue how to nail it down. In the meantime we found that we need some gossip on higher level which keeps the connection open anyway. But it would be great if you could finish it. Thanks. |
We should rebase and see what's the CI says. |
This PR now conflicts with the main branch. I personally think it could be merged even without a test. But that's not my say. @cescoffier @michalszynkiewicz what should we do with it? |
Great, thanks! |
While using gRPC server side stream we are facing stream termination due to short tcp idle time on loadbalancer. There is configuration options in netty server which are not exposed presently.
With this the netty keep-alive is exposed as
quarkus.grpc.server.netty.keep-alive-time
where we can set a Duration.