Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that Kotlin entities do not extend PanacheEntity and also declare its own ID #13829

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Validate that Kotlin entities do not extend PanacheEntity and also declare its own ID #13829

merged 1 commit into from
Dec 11, 2020

Conversation

evanchooly
Copy link
Member

validate for multiple ID annotations like the java side does
convert the tests to kotlin

fixes #11887

@ghost ghost added the area/panache label Dec 10, 2020
loicmathieu
loicmathieu approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FroMage FroMage merged commit 7bcd4dc into quarkusio:master Dec 11, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 11, 2020
@evanchooly evanchooly deleted the issue11887 branch December 11, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/panache
Projects
None yet
Milestone
1.11.0.Beta1
Development

Successfully merging this pull request may close these issues.

Kotlin Hibernate with Panache didn't validate bad usage of PanacheEntity
3 participants
@evanchooly @FroMage @loicmathieu