Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin Hibernate with Panache didn't validate bad usage of PanacheEntity #11887

Closed
loicmathieu opened this issue Sep 4, 2020 · 2 comments · Fixed by #13829
Closed

Kotlin Hibernate with Panache didn't validate bad usage of PanacheEntity #11887

loicmathieu opened this issue Sep 4, 2020 · 2 comments · Fixed by #13829
Assignees
@evanchooly
Labels
area/hibernate-orm Hibernate ORM area/kotlin area/panache area/persistence OBSOLETE, DO NOT USE kind/bug Something isn't working
Milestone
1.11.0.Beta1

Comments

@loicmathieu
Copy link
Contributor

Describe the bug
Kotlin Hibernate with Panache should have the same validation phase as the Java version that detects that PanacheEntity is not used by an entity that defines an @Id.

Expected behavior
The Kotlin version must run the same validation phase as in the io.quarkus.hibernate.orm.panache.deployment.PanacheHibernateResourceProcessor.validate() and must include the same tests to check for duplicate ID: io.quarkus.hibernate.orm.panache.deployment.test.DuplicateIdEntityTest and io.quarkus.hibernate.orm.panache.deployment.test.DuplicateIdWithParentTest.
@loicmathieu loicmathieu added the kind/bug Something isn't working label Sep 4, 2020
@loicmathieu
Copy link
Contributor Author

/cc @evanchooly

@quarkusbot
Copy link

/cc @evanchooly
/cc @FroMage
/cc @gsmet, @Sanne

@quarkusbot quarkusbot added the area/persistence OBSOLETE, DO NOT USE label Sep 4, 2020
@evanchooly evanchooly self-assigned this Sep 4, 2020
@evanchooly evanchooly mentioned this issue Dec 10, 2020
Merged
@ghost ghost added this to the 1.11 - master milestone Dec 11, 2020
cemnura pushed a commit to cemnura/quarkus that referenced this issue Dec 22, 2020
@evanchooly @cemnura
validate for multiple ID annotations like the java side does
5e30703 
convert the tests to kotlin

fixes quarkusio#11887
renegrob pushed a commit to renegrob/quarkus that referenced this issue Dec 23, 2020
@evanchooly @renegrob
validate for multiple ID annotations like the java side does
8c73b96 
convert the tests to kotlin

fixes quarkusio#11887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evanchooly evanchooly

Labels
area/hibernate-orm Hibernate ORM area/kotlin area/panache area/persistence OBSOLETE, DO NOT USE kind/bug Something isn't working
Projects
None yet
Milestone
1.11.0.Beta1
Development

Successfully merging a pull request may close this issue.

Validate that Kotlin entities do not extend PanacheEntity and also declare its own ID
3 participants
@evanchooly @loicmathieu @quarkusbot