Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move VaultRuntimeConfig to BOOTSTRAP phase #13498

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Move VaultRuntimeConfig to BOOTSTRAP phase #13498

merged 1 commit into from
Nov 27, 2020

Conversation

vsevel
Copy link
Contributor

@vsevel vsevel commented Nov 26, 2020 •
edited
Loading

Reopening of #9989 now that #13300 has been fixed (the issue was in the vault extension; so #9991 was invalid). approach suggested in #4848 (comment)
This allow to drop the entire config parsing reimplementation that was done in the VaultConfigSource. this is a huge win in terms of logic duplication, and behavior consistency.

@vsevel vsevel mentioned this pull request Nov 26, 2020
Closed
@vsevel vsevel requested a review from geoand November 26, 2020 21:28
@vsevel vsevel mentioned this pull request Nov 27, 2020
Closed
@geoand
Copy link
Contributor

geoand commented Nov 27, 2020 •
edited
Loading

Thanks a lot @vsevel!

This simplifies things a lot, you have my +1!
@gastaldi mind taking a quick look at this as well?

gastaldi
gastaldi approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit d51cbc0 into quarkusio:master Nov 27, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 27, 2020
@vsevel vsevel deleted the vault_config_boostrap branch November 27, 2020 11:12
@vsevel
Copy link
Contributor Author

vsevel commented Nov 27, 2020

thanks

@vsevel vsevel mentioned this pull request Nov 27, 2020
Closed
@vsevel vsevel mentioned this pull request Dec 13, 2020
Closed
@vsevel vsevel mentioned this pull request Jan 12, 2021
Closed
@vsevel vsevel mentioned this pull request Jan 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/core area/testing area/vault
Projects
None yet
Milestone
1.11.0.Beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@vsevel @geoand @gastaldi