Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secret-config-kv-prefix-path property #13300

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Fix secret-config-kv-prefix-path property #13300

merged 1 commit into from
Nov 26, 2020

Conversation

vsevel
Copy link
Contributor

@vsevel vsevel commented Nov 15, 2020

This changes property quarkus.vault.secret-config-kv-path.singer=multi/singer1,multi/singer2 into quarkus.vault.secret-config-kv-prefix.singer.paths=multi/singer1,multi/singer2 (configuration breaking change)
The original approach (reusing the same name for the prefixed properties and non prefixed properties) seemed to work, but only because the re-parsing of configuration done in the VaultConfigSource was doing the right thing.

Fixes #13276

@vsevel
Copy link
Contributor Author

vsevel commented Nov 25, 2020

hello all, I have squashed commits and rebased. I think the result is looking good thanks for @machi1990 's help.
@sberyozkin feel free to take a look and make sure its matches your expectations.

@sberyozkin
Copy link
Member

Hi @vsevel, @machi1990 Thanks, it looks good; @machi1990 thanks for your help :-)

@sberyozkin sberyozkin self-requested a review November 25, 2020 10:07
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsevel, Gradle test is failing, most likely it is unrelated, but please rebase one more time

@machi1990
Copy link
Member

Hi @vsevel, @machi1990 Thanks, it looks good; @machi1990 thanks for your help :-)

hello all, I have squashed commits and rebased. I think the result is looking good thanks for @machi1990 's help.
@sberyozkin feel free to take a look and make sure its matches your expectations.

You are welcome :-)

@vsevel
Copy link
Contributor Author

vsevel commented Nov 25, 2020

@sberyozkin build failed again, this time on the Microprofile TCK
is there any way to restart only the failed step?

@vsevel
Copy link
Contributor Author

vsevel commented Nov 26, 2020

@sberyozkin failed build again because of the global timeout set on the maven build (3h). not too sure what I should do.

@sberyozkin
Copy link
Member

sberyozkin commented Nov 26, 2020

@vsevel IMHO it is safe to merge this PR as all the Vault tests pass

@sberyozkin sberyozkin merged commit c181471 into quarkusio:master Nov 26, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 26, 2020
@vsevel vsevel deleted the vault_map_prop branch November 26, 2020 12:28
@vsevel
Copy link
Contributor Author

vsevel commented Nov 26, 2020

thanks to all of you for your assistance in the review and figuring out how to implement the best solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid warning on quarkus.vault.secret-config-kv-path."prefix" property
4 participants