Add jsonp for cases where jsonb is not in scope #12635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Oct 9, 2020
loicmathieu
force-pushed
the
oauth2-jsonp
branch
from
062611b to
a555399
Compare
|
Sorry I was too hurry, fixed. |
gsmet
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
quarkus-jsonpdependency for cases wherequarkus-jsonbis not in scope.I hesitate to add only
org.glassfish:jakarta.jsonas it's the needed dependency to fix the issue, but as I understand itquarkus-jsonbis the integration of this library inside Quarkus so I prefere to add it.Without it native image generation is not possible when an application didn't include
quarkus-jsonb(I doubt the application even works) due tocom.oracle.graal.pointsto.constraints.UnresolvedElementException: Discovered unresolved type during parsing: javax.json.JsonObject.Part of #12625 but not full fix as the issue references two problems.