quarkus-elytron-security-oauth2 does not work as described in documentation #12625
Comments
|
@loicmathieu Hi Loic - can you please have a look, thanks |
|
Hello, Problem 1: the behaviour is normal as the configuration was not done inside Problem 2: as I understand it, using elytron-security-oauth2 without JSONB (for example with only |
|
#12635 should fix the native image issue (Problem 2). |
Yes for example a project that not even uses JSONB or a project that uses jackson. There it would be just confusing to add jsonb even though it is not directly used by the project, but required to add to make
Don't fully agree on that here, since for me as a user of quarkus it would be better and easier to understand to have a self contained example that works out of the box. But clearly that was not you intention here. |
So what do you propose here ? For OAuth2 to work we need an OAuth2 server. Typically, a user will use embedded security in localhost and OAuth2 when deploying on a server. We already explained a little later on the guide how to mock an OAuth2 server for integration test but for local if you don't want to use an embedded authentication you must configure a valid OAuth2 server. |
It is all fine what you write here, my point only was that the test should run out of the box which does not seem to work. |
|
OK then, I think the best is to improve the documentation. If you follow the OAuth2 guide, it means you want to test OAuth2 so for me it's OK that you have an error as long as you didn't configure OAuth. I'll create an issue to describe the modifications I proposes for the security guides (mostly re-organizing them to have more logical steps by moving the configuration part upper). When done I'll propose to close this one if you'll agree. Anyway, thanks for your feedback, we try to make our best to have a good experience when using the guides, so we appreciate all feedback on them ;) |
That is fine, proceed as fits best for you :-) |
|
Thanks ;) I improve the guide with more logical steps in the PR: #12742 |
there are two problems with the documentation found at https://quarkus.io/guides/security-oauth2
Problem1:
Describe the bug
open https://quarkus.io/guides/security-oauth2
go to
run
Expected behavior
tests and build runs fine with mvn clean install -Pnative
Actual behavior
Problem2:
Describe the bug
the documentation open https://quarkus.io/guides/security-oauth2 states the following:
which does not work out of the box
if you have a project not containing the following dependency e.g. a project that is using jackson
and you run mvn clean install -Pnative you will get
Actual behavior
** Expected behaviour
When following the documentation
mvn install -Pnativeshould produce a valid native runnermaybe add to the documentation
If you don’t want to use the Maven plugin, you can just include the dependencies in your pom.xml:
** How to reproduce add the
clone: https://github.com/ineednousername/reproducer-elytron
run: mvn clean install -Pnative -DskipTests
The text was updated successfully, but these errors were encountered: