Use the deployment dependencies in the gRPC deployment artifact #11169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use the runtime one, it is then impossible to make a partial build with an empty repo as the deployment dependencies are not properly dragged.
|
@geoand could you have a look at that one? I'd like to get it in as soon as CI is green as it's in the way for what I'm working on currently. It's the usual "don't use runtime dependencies in deployment artifacts" one. |
geoand
approved these changes
Aug 3, 2020
|
Next week I want to start working on #10859 where I am planning to introduce a custom enforcer rule that checks for deployment dependencies of runtime artifacts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use the runtime one, it is then impossible to make a partial
build with an empty repo as the deployment dependencies are not properly
dragged.