Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel build fails with invalid order of building #10859

Closed
michalszynkiewicz opened this issue Jul 20, 2020 · 4 comments · Fixed by #11331
Closed

Parallel build fails with invalid order of building #10859

michalszynkiewicz opened this issue Jul 20, 2020 · 4 comments · Fixed by #11331
Assignees
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/bug Something isn't working
Milestone

Comments

@michalszynkiewicz
Copy link
Member

Code Gen needs deployment modules of Quarkus extensions to be available during generate-sources phase of maven build of integration tests.
This dependency is not know to maven and a parallel build can fail with:

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:prepare (default) on project quarkus-integration-test-grpc-tls: Prepare phase of the quarkus-maven-plugin threw an error: Failed to create the application model for io.quarkus:quarkus-integration-test-grpc-tls::jar:999-SNAPSHOT: Failed to resolve artifacts: The following artifacts could not be resolved: io.quarkus:quarkus-resteasy-mutiny-deployment:jar:999-SNAPSHOT, io.quarkus:quarkus-grpc-deployment:jar:999-SNAPSHOT: Failure to find io.quarkus:quarkus-resteasy-mutiny-deployment:jar:999-SNAPSHOT in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]
[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:prepare (default) on project quarkus-integration-test-grpc-mutual-auth: Prepare phase of the quarkus-maven-plugin threw an error: Failed to create the application model for io.quarkus:quarkus-integration-test-grpc-mutual-auth::jar:999-SNAPSHOT: Failed to resolve artifacts: The following artifacts could not be resolved: io.quarkus:quarkus-resteasy-mutiny-deployment:jar:999-SNAPSHOT, io.quarkus:quarkus-grpc-deployment:jar:999-SNAPSHOT: Failure to find io.quarkus:quarkus-resteasy-mutiny-deployment:jar:999-SNAPSHOT in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]

With skipped test, It doesn't happen with the usual quarkus-maven-plugin run because setting skipTests sets quarkus.build.skip to true.

Setting quarkus.prepare.skip to true in this case would cause java compilation to fail, so we need to figure out another way to solve it.

@michalszynkiewicz michalszynkiewicz added the kind/bug Something isn't working label Jul 20, 2020
@michalszynkiewicz michalszynkiewicz self-assigned this Jul 20, 2020
@famod
Copy link
Member

famod commented Jul 20, 2020

See also: ongoing discussion on zulip

@famod famod added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jul 20, 2020
@famod
Copy link
Member

famod commented Jul 20, 2020

Not sure about the area/housekeeping but since this is not a user-facing bug I felt I had to add something...

@famod
Copy link
Member

famod commented Jul 21, 2020

@michalszynkiewicz In case no objections are raised on zulip (or here): Do you want to introduce those deployment dependecies or can/shall I do it?

@michalszynkiewicz
Copy link
Member Author

@famod if you have time for it, I'd be grateful :)

@famod famod assigned famod and unassigned michalszynkiewicz Jul 26, 2020
gastaldi pushed a commit to gastaldi/quarkus that referenced this issue Aug 26, 2020
Fixes quarkusio#10859 by enforcing a consistent build order.

Presence of such minimal dependencies is enforced by the new RequiresMinimalDeploymentDependency rule.
gastaldi pushed a commit to gastaldi/quarkus that referenced this issue Aug 26, 2020
Fixes quarkusio#10859 by enforcing a consistent build order.

Presence of such minimal dependencies is enforced by the new RequiresMinimalDeploymentDependency rule.
@gsmet gsmet added this to the 1.8.0.CR1 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants