Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed support for GraalVM 19.x #10839

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Removed support for GraalVM 19.x #10839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c79d8d2
Adapt the checking function in NativeImageBuildStep
Sanne Jul 19, 2020
7e3f5ad
Prefer using GraalVM 20.1 UBI images in Gradle tooling examples
Sanne Jul 19, 2020
10e79e8
Use graalvm-flavor attribute in amazon-lambda.adoc and gradle-tooling…
gsmet Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,11 +424,11 @@ private RuntimeException imageGenerationFailed(int exitValue, List<String> comma

private void checkGraalVMVersion(String version) {
log.info("Running Quarkus native-image plugin on " + version);
final List<String> obsoleteGraalVmVersions = Arrays.asList("1.0.0", "19.0.", "19.1.", "19.2.", "19.3.0", "20.0.");
final List<String> obsoleteGraalVmVersions = Arrays.asList("1.0.0", "19.0.", "19.1.", "19.2.", "19.3.", "20.0.");
final boolean vmVersionIsObsolete = obsoleteGraalVmVersions.stream().anyMatch(v -> version.contains(" " + v));
if (vmVersionIsObsolete) {
throw new IllegalStateException("Out of date version of GraalVM detected: " + version + "."
+ " Quarkus currently supports GraalVM 19.3.2 and 20.1.0. Please upgrade GraalVM to one of these versions.");
+ " Quarkus currently supports 20.1.0. Please upgrade GraalVM to this version.");
}
}

Expand Down
6 changes: 3 additions & 3 deletions docs/src/main/asciidoc/amazon-lambda.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ For Maven, add the following to your `pom.xml`.
</dependencies>
----

NOTE: if you are using GraalVM earlier than 19.3, or see `java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty` or similar SSL error, due to the current status of GraalVM,
NOTE: if you see `java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty` or similar SSL error, due to the current status of GraalVM,
there is some additional work to bundle the `function.zip`, as below. For more information, please see the link:native-and-ssl[Quarkus Native SSL Guide].

== Additional requirements for client SSL
Expand Down Expand Up @@ -631,9 +631,9 @@ NOTE: If you are using a Docker image to build, then you must extract these file
To extract the required ssl, you must start up a Docker container in the background, and attach to that container to copy the artifacts.

First, let's start the GraalVM container, noting the container id output.
[source, shell]
[source, shell,subs=attributes+]
----
docker run -it -d --entrypoint bash quay.io/quarkus/ubi-quarkus-native-image:19.3.1-java8
docker run -it -d --entrypoint bash quay.io/quarkus/ubi-quarkus-native-image:{graalvm-flavor}

# This will output a container id, like 6304eea6179522aff69acb38eca90bedfd4b970a5475aa37ccda3585bc2abdde
# Note this value as we will need it for the commands below
Expand Down
6 changes: 3 additions & 3 deletions docs/src/main/asciidoc/gradle-tooling.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,18 +312,18 @@ The `buildNative` task has been deprecated in favor of
Native related properties can either be added in `application.properties` file, as command line arguments or in the `quarkusBuild` task.
Configuring the `quarkusBuild` task can be done as following:

[source,groovy]
[source,groovy,subs=attributes+]
----
quarkusBuild {
nativeArgs {
containerBuild = true <1>
buildImage = "quay.io/quarkus/ubi-quarkus-native-image:19.3.1-java11" <2>
buildImage = "quay.io/quarkus/ubi-quarkus-native-image:{graalvm-flavor}" <2>
}
}
----

<1> Set `quarkus.native.containerBuild` property to `true`
<2> Set `quarkus.native.buildImage` property to `quay.io/quarkus/ubi-quarkus-native-image:19.3.1-java11`
<2> Set `quarkus.native.buildImage` property to `quay.io/quarkus/ubi-quarkus-native-image:{graalvm-flavor}`


=== Build a container friendly executable
Expand Down