Removed support for GraalVM 19.x #10839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
previously requested changes
Jul 20, 2020
There was a problem hiding this comment.
There are still other places where 19.3.1 is used. This is what grep returned to me:
./docs/src/main/asciidoc/amazon-lambda.adoc:636:docker run -it -d --entrypoint bash quay.io/quarkus/ubi-quarkus-native-image:19.3.1-java8
./docs/src/main/asciidoc/README.adoc:48:|\{graalvm-flavor}|{graalvm-flavor}| The full flavor of GraaVM to use e.g. `19.3.1-java11`.
|
@gastaldi the second one is just an example, we don't need to update it but the first one should have used the attribute. I will fix it. |
|
I fixed a couple more occurrences too. |
gsmet
approved these changes
Jul 20, 2020
gsmet
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was simpler than expected, as I couldn't find any integration tests based on GraalVM 19 to disable / remove. Is that correct?
Fixes #10838