Update Reactive Messaging to version 2.2.0 and Integrate health support #10831
Conversation
boring-cyborg
bot
added
area/dependencies
Also fix the durability bug when sending messages to a non-durable AMQP address
cescoffier
force-pushed
the
features/reactive-messaging-health
branch
from
bc66eb3 to
0dd61af
Compare
| @ConfigRoot(name = "reactive-messaging", phase = ConfigPhase.BUILD_TIME) | ||
| public class ReactiveMessagingBuildTimeConfig { | ||
| /** | ||
| * Whether or not an health check is published in case the smallrye-health extension is present. |
There was a problem hiding this comment.
Is the in case... part true? AFAICS, you always drag the smallrye-health dependency.
There was a problem hiding this comment.
It only depends on the SPI, not on the extension itself.
There was a problem hiding this comment.
You sure? smallrye-reactive-messaging-health doesn't depend on health?
Because if you don't have health, I'm surprised this can work: https://github.com/quarkusio/quarkus/pull/10831/files#diff-0e5b3cb2b027d18a3e49591822e8c947R310 . You would need to use a string for the class name as there's a good chance you wouldn't be able to load the checks if health is not present.
There was a problem hiding this comment.
smallrye-reactive-messaging-health depends on microprofile health not on the quarkus extension.
There was a problem hiding this comment.
https://github.com/quarkusio/quarkus/pull/10831/files#diff-0e5b3cb2b027d18a3e49591822e8c947R310 refers to classes from reactive messaging (in a specific module that depends on microprofile health).
There was a problem hiding this comment.
I just re-tested it does not pull quarkus-health, it's up to the user to use it.
There was a problem hiding this comment.
We discussed this with @cescoffier on Zulip. Let's merge as is even if not entirely consistent with the other SmallRye extensions.
No description provided.