-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Integrate health support to reactive messaging.
Also fix the durability bug when sending messages to a non-durable AMQP address
- Loading branch information
1 parent
1c416eb
commit 0dd61af
Showing
8 changed files
with
61 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -231,7 +231,6 @@ amqp-password=quarkus | |
# Configure the AMQP connector to write to the `prices` address | ||
mp.messaging.outgoing.generated-price.connector=smallrye-amqp | ||
mp.messaging.outgoing.generated-price.address=prices | ||
mp.messaging.outgoing.generated-price.durable=true | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
Ladicek
Contributor
|
||
# Configure the AMQP connector to read from the `prices` queue | ||
mp.messaging.incoming.prices.connector=smallrye-amqp | ||
|
1 change: 0 additions & 1 deletion
1
...ons/smallrye-reactive-messaging-amqp/deployment/src/test/resources/application.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
...va/io/quarkus/smallrye/reactivemessaging/deployment/ReactiveMessagingBuildTimeConfig.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package io.quarkus.smallrye.reactivemessaging.deployment; | ||
|
||
import io.quarkus.runtime.annotations.ConfigItem; | ||
import io.quarkus.runtime.annotations.ConfigPhase; | ||
import io.quarkus.runtime.annotations.ConfigRoot; | ||
|
||
@ConfigRoot(name = "reactive-messaging", phase = ConfigPhase.BUILD_TIME) | ||
public class ReactiveMessagingBuildTimeConfig { | ||
/** | ||
* Whether or not an health check is published in case the smallrye-health extension is present. | ||
*/ | ||
@ConfigItem(name = "health.enabled", defaultValue = "true") | ||
public boolean healthEnabled; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was hit by this change and it took me quite some time to figure it out.
First I thought there is regression in smallrye-reactive-messaging-amqp 2.2.1 because when I used 2.1.1 tests were passing for me.
@gsmet / @cescoffier almost feels like an item for https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.7 to warn users. If users followed QS or guide they would be stuck as I was.