Revert "Simplify runtime class transformation" #10398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 18f1ca2.
boring-cyborg
bot
added
area/core
area/devtools
geoand
approved these changes
Jul 1, 2020
aloubyansky
approved these changes
Jul 1, 2020
|
Maybe we shouldn't revert it in master though? Creating an issue instead? |
|
We already have an issue. I prefer doing it in both branches because if we don't have time to fix it by 1.7, I wouldn't want it to resurface. It's easy enough to re-revert it. |
Postremus
approved these changes
Jul 1, 2020
|
/cc @stuartwdouglas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DO NOT MERGE YET. I want CI to run on it but @aloubyansky might come with a proper fix before the release.
This is a reminder so that I do not forget to revert it in case we don't have a better option.
This reverts commit 18f1ca2.
/cc @geoand @aloubyansky @Postremus