-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.6.0.CR1 - Random Classloading Problems #10371
Comments
@Postremus thanks for reporting. Looks like a nasty one but also probably something that will be hard to track. If you end up finding a way to reproduce it, that would be very helpful. In any case, I'm not entirely sure we will be able to fix that one for 1.6.0. |
@Postremus just in case, would you be able to test a custom branch of Quarkus repo to help debug the issue? |
@aloubyansky yes, I can test custom branches / revisions. |
I am wondering whether the regression was caused by commit |
@Postremus What you can additionally do (to provide us some debug data) is pass the following when you launch the application in quarkus:dev mode:
I've intentionally redirected the output to a file since the output is going to be extremely large. Share the file with us (after you have managed to generate the classcast/classloading error). |
@aloubyansky dev mode works in both @jaikiran Can I send you the log privatly trough zulip? |
@Postremus two more commits to try if you could: 18f1ca2 and 4e58a7d |
@geoand @aloubyansky dev mode does not work with Dev mode works in the commit directly before that, |
@Postremus thanks a lot for that info, it's very helpful. If you could perform one final check so we can absolutely positive that it's that commit that causes the problem: Can you test the latest @aloubyansky any idea why that might be happening with the commit in question (18f1ca2)? Looks to me like we can safely revert it need be. |
I have been trying to avoid joining too many chat/email applications, so I'm not on Zulip, sorry. But if you are willing to send me that log over email, then my address is ... (email has been received, removing address from this message) |
I reverted the commit in question on master. Dev mode works. |
I just wanted to say good work everyone :). |
Unable to see this in action, I personally can't really tell what the actual problem with that commit is. So all I have to offer is the suggestion to revert. By just eyeballing I am inclined to think it might have to do with |
I'll create a branch and push a commit to see if it fixes the issue. But I'm afk atm :( |
BTW, I had the same suspicion as @geoand |
This revert seems to fix at least one more problem: When I build from @Postremus' branch and use that SNAPSHOT of Quarkus in my project then the no-arg constructor problem vanishes! Does that make sense? PS: My main CCE-problem persists though, but that is another topic. |
I kinda makes sense if the transformer handling breaks (no-args constructors are in some cases added via a transformation) |
@stuartwdouglas FYI, in case you missed it, due to this issue (and a few other cases reported), we had to revert your work in #10398 for 1.6.0.Final. |
Yea, I have just not had time to look into it. It's not a hight priority, it just seemed like it would be a code simplification. |
Hello @gsmet, OK to close this one? Given that the issue has been sorted out by reverting the commit? |
I think I can see the problem and I have made another attempt at this for 1.8: #11214 This change does simplify things and will allow for some nice optimisations in dev mode, so I do want to get it in. |
Describe the bug
I have a rather big project running in quarkus 1.5.2.Final without problems.
This project has about 130 modules.
Today, I tried out if there are any regressions with quarkus 1.6.
The project does not start any more in dev mode. It works fine when run as jar (in docker).
Problem looks related to classes being loaded multiple times by different instances of the classloader.
In the stacktrace below, BasePlainEntity is an
@MappedSupperClass
, used in multiple classes and modules.The
BasePlainEntity
itself is from another external module.The same stacktrace also happens randomly for different classes, most often though for
BasePlainEntity
.Expected behavior
No Classloading problems during startup.
Actual behavior
Stacktrace always looks like this,
AnnotationMetaDataProvider
is the last class called before classloading stuff happens.To Reproduce
No idea how to reproduce it. I was not able to create a small reproducer project yet.
Environment (please complete the following information):
uname -a
orver
:MSYS_NT-10.0 NANB7NLNVP2 2.10.0(0.325/5/3) 2018-06-13 23:34 x86_64 Msys
1.6.0.CR1
mvnw --version
orgradlew --version
):Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\eclipse\tools\apache-maven\bin..
Java version: 11.0.7, vendor: Azul Systems, Inc., runtime: C:\eclipse\tools\zulu11.39.15-ca-jdk11.0.7-win_x64
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
The text was updated successfully, but these errors were encountered: