Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support uber jar for native image source jar #8850

Closed
Mobe91 opened this issue Apr 25, 2020 · 0 comments · Fixed by #8860
Closed

Support uber jar for native image source jar #8850

Mobe91 opened this issue Apr 25, 2020 · 0 comments · Fixed by #8860
Labels
kind/enhancement New feature or request
Milestone
1.6.0.CR1

Comments

@Mobe91
Copy link
Contributor

Mobe91 commented Apr 25, 2020

Description
Currently, quarkus-maven-plugin ignores the uberJar option for native image builds. However, using an uber jar as native image source jar can be used as a workaround for a current GraalVM limitation on Windows.

Implementation ideas
Reuse the existing uber jar creation logic in the quarkus-maven-plugin for native image source jar creation if the uberJar option is enabled.
@Mobe91 Mobe91 added the kind/enhancement New feature or request label Apr 25, 2020
Mobe91 added a commit to Mobe91/quarkus that referenced this issue Apr 26, 2020
@Mobe91
[quarkusio#8850] Generate uber jar for native image source jar if the…
0314787 
… uberJar option of quarkus-maven-plugin is enabled
@Mobe91 Mobe91 mentioned this issue Apr 26, 2020
Merged
Mobe91 added a commit to Mobe91/quarkus that referenced this issue Apr 28, 2020
@Mobe91
[quarkusio#8850] Enable uber jar strategy for Windows automatically a…
199c4a9 
…nd add in-code documentation plus logging
Mobe91 added a commit to Mobe91/quarkus that referenced this issue May 27, 2020
@Mobe91
[quarkusio#8850] Generate uber jar for native image source jar if the…
5e4c83d 
… uberJar option of quarkus-maven-plugin is enabled
Mobe91 added a commit to Mobe91/quarkus that referenced this issue May 27, 2020
@Mobe91
[quarkusio#8850] Enable uber jar strategy for Windows automatically a…
450776c 
…nd add in-code documentation plus logging
Mobe91 added a commit to Mobe91/quarkus that referenced this issue May 29, 2020
@Mobe91
[quarkusio#8850] Change windows logic for uber jar generation
f86565a
stuartwdouglas added a commit that referenced this issue Jun 1, 2020
@stuartwdouglas
Merge pull request #8860 from Mobe91/feature/8850-uber-jar-support-fo…
f1f0b11 
…r-native-image-source

[#8850] Generate uber jar for native image source jar if the uberJar option of quarkus-maven-plugin is enabled
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 10, 2020
johnaohara pushed a commit to johnaohara/quarkus that referenced this issue Jun 29, 2020
@Mobe91 @johnaohara
[quarkusio#8850] Generate uber jar for native image source jar if the…
6ca5aaa 
… uberJar option of quarkus-maven-plugin is enabled
johnaohara pushed a commit to johnaohara/quarkus that referenced this issue Jun 29, 2020
@Mobe91 @johnaohara
[quarkusio#8850] Enable uber jar strategy for Windows automatically a…
05c26e6 
…nd add in-code documentation plus logging
johnaohara pushed a commit to johnaohara/quarkus that referenced this issue Jun 29, 2020
@Mobe91 @johnaohara
[quarkusio#8850] Change windows logic for uber jar generation
894a98d
@jaikiran jaikiran mentioned this issue Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
1.6.0.CR1
2 participants
@gsmet @Mobe91