Skip to content

Commit

Permalink
[quarkusio#8850] Change windows logic for uber jar generation
Browse files Browse the repository at this point in the history
  • Loading branch information
Mobe91 authored and johnaohara committed Jun 29, 2020
1 parent 05c26e6 commit 894a98d
Showing 1 changed file with 4 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -628,13 +628,10 @@ public NativeImageSourceJarBuildItem buildNativeImageJar(CurateOutcomeBuildItem
.map((s) -> new GeneratedClassBuildItem(true, s.getName(), s.getClassData()))
.collect(Collectors.toList()));

boolean uberJarRequested = !uberJarRequired.isEmpty() || packageConfig.uberJar;
if (uberJarRequested || IS_WINDOWS) {
if (!uberJarRequested) {
log.warn("Uber JAR strategy is used for native image source JAR generation on Windows. This is done " +
"for the time being to work around a current GraalVM limitation on Windows concerning the " +
"maximum command length (see https://github.com/oracle/graal/issues/2387).");
}
if (IS_WINDOWS) {
log.warn("Uber JAR strategy is used for native image source JAR generation on Windows. This is done " +
"for the time being to work around a current GraalVM limitation on Windows concerning the " +
"maximum command length (see https://github.com/oracle/graal/issues/2387).");
// Native image source jar generation with the uber jar strategy is provided as a workaround for Windows and
// will be removed once https://github.com/oracle/graal/issues/2387 is fixed.
return buildNativeImageUberJar(curateOutcomeBuildItem, outputTargetBuildItem, transformedClasses,
Expand Down

0 comments on commit 894a98d

Please sign in to comment.