Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev mode doesn't recover when an invalid value (typo, space) is added to logging level configuration #8534

Closed
rsvoboda opened this issue Apr 10, 2020 · 0 comments · Fixed by #8677
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@rsvoboda
Copy link
Member

Dev mode doesn't recover when an invalid value (typo, space) is added to logging level configuration
When the value is corrected, Quarkus still isn't able to restart itself.

Reproducer:

mvn io.quarkus:quarkus-maven-plugin:1.3.2.Final:create \
    -DprojectGroupId=org.acme \
    -DprojectArtifactId=getting-started \
    -DclassName="org.acme.getting.started.GreetingResource" \
    -Dpath="/hello"
cd getting-started
mvn quarkus:dev

open src/main/resources/application.properties
add 'quarkus.log.category."org.hibernate".level=DEBUG ' (extra space at the end) into application.properties
open http://localhost:8080/hello
remove extra space at the end of quarkus.log.category line in application.properties
open http://localhost:8080/hello

Log reports:

2020-04-10 22:16:26,799 INFO  [io.qua.dev] (vert.x-worker-thread-2) File change detected: /Users/rsvoboda/Downloads/ffff/getting-started/src/main/resources/application.properties
2020-04-10 22:16:26,824 INFO  [io.quarkus] (vert.x-worker-thread-2) Quarkus stopped in 0.021s

Stacktrace from http://localhost:8080/hello

io.quarkus.runtime.configuration.ConfigurationException: One or more configuration errors has prevented the application from starting. The errors are:
An invalid value was given for configuration key "quarkus.log.category."org.hibernate".level": java.lang.reflect.InvocationTargetException
Resulted in: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:232)
	at io.quarkus.runtime.Application.start(Application.java:90)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.runner.bootstrap.StartupActionImpl.run(StartupActionImpl.java:99)
	at io.quarkus.dev.IsolatedDevModeMain.restartApp(IsolatedDevModeMain.java:103)
	at io.quarkus.dev.RuntimeUpdatesProcessor.doScan(RuntimeUpdatesProcessor.java:138)
	at io.quarkus.vertx.http.runtime.devmode.VertxHotReplacementSetup$1.handle(VertxHotReplacementSetup.java:50)
	at io.quarkus.vertx.http.runtime.devmode.VertxHotReplacementSetup$1.handle(VertxHotReplacementSetup.java:42)
	at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$2(ContextImpl.java:316)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:834)
@rsvoboda rsvoboda added the kind/bug Something isn't working label Apr 10, 2020
@stuartwdouglas stuartwdouglas self-assigned this Apr 20, 2020
stuartwdouglas added a commit to stuartwdouglas/quarkus that referenced this issue Apr 20, 2020
This means config failures won't be recovered in dev mode

Also fix race where the 'press enter to restart' error message may
appear on restart.

Fixes quarkusio#8534
@gsmet gsmet added this to the 1.4.0.Final milestone Apr 20, 2020
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 20, 2020
This means config failures won't be recovered in dev mode

Also fix race where the 'press enter to restart' error message may
appear on restart.

Fixes quarkusio#8534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants