Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OOTB experience with extensions for newly generated projects #8506

Closed
1 task
rsvoboda opened this issue Apr 9, 2020 · 10 comments
Closed
1 task

Improve OOTB experience with extensions for newly generated projects #8506

rsvoboda opened this issue Apr 9, 2020 · 10 comments
Labels
kind/epic Large issue with links to sub-issues

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Apr 9, 2020

Description

Improve OOTB experience with extensions for newly generated projects.

There are several extension which are requiring configuration eagerly and this breaks "1) generate the bootstrap app 2) run dev mode 3) enjoy" flow / developer joy.

Analysis

Identified extensions needing initial configuration:

# no longer needed, quarkus-smallrye-jwt works out of the box
# mp.jwt.verify.publickey=asd
# mp.jwt.verify.publickey.location=/foo/bar

# Flyway minimal config properties
quarkus.flyway.migrate-at-start=false

# Flyway needs to configure a datasource
quarkus.datasource.url=jdbc:postgresql://localhost:5432/mydatabase
quarkus.datasource.driver=org.postgresql.Driver
quarkus.datasource.username=sarah
quarkus.datasource.password=connor

quarkus.kafka-streams.application-id=foo-id
quarkus.kafka-streams.topics=kafka-topic

quarkus.artemis.url=foo
quarkus.qpid-jms.url=bar

quarkus.oauth2.client-id=client_id
quarkus.oauth2.client-secret=secret
quarkus.oauth2.introspection-url=http://oauth-server/introspect

quarkus.oidc.auth-server-url=https://localhost:8180/auth/realms/quarkus
quarkus.oidc.client-id=quarkus-app

quarkus.oidc-client.auth-server-url=http://localhost:6661/auth/realms/quarkus
quarkus.oidc-client.client-id=666
quarkus.oidc-client.token-path=token
quarkus.oidc-client.discovery-enabled=false

Note: this list was composed some time ago (~ 2020-03-10), anyway, a good starting point.

Tasks

__TODO__

  • Checklist of sub tasks goes here, represented as links to GitHub issues
@rsvoboda rsvoboda added the kind/epic Large issue with links to sub-issues label Apr 9, 2020
@sberyozkin
Copy link
Member

Re OIDC, it has a tenant-enable property set to true by default. IMHO it would not be ideal to start without the OIDC server being around in a non-dev mode so I'm not sure how to deal with it such that it is possible to add the connection properties in the dev mode but not in the dev mode. CC @stuartwdouglas

@rsvoboda
Copy link
Member Author

@maxandersen / @paulrobinson please create tasks / checklist of needed actions

I didn't want to interfere in that section with your common workflow.

Should things like #8534 be part of this epic too?

@maxandersen
Copy link
Member

@rsvoboda yeah #8534 is relevant too!

@sberyozkin
Copy link
Member

quarkus-smallrye-jwt will not need an initial configuration in Quarkus 1.5.0

@rsvoboda
Copy link
Member Author

Adding quarkus.qpid-jms.url to the set of required properties

@rsvoboda
Copy link
Member Author

rsvoboda commented Mar 7, 2021

Adding quarkus.oidc-client related properties

@sberyozkin
Copy link
Member

sberyozkin commented Mar 26, 2021

@rsvoboda #16060 will fix it for quarkus-oidc and quarkus-oidc-client

@rsvoboda
Copy link
Member Author

quarkus-qpid-jms has better initial experience now, no extra config needed for generated project

@geoand
Copy link
Contributor

geoand commented Feb 27, 2024

Is there anything more to be done around this?

@rsvoboda
Copy link
Member Author

I think the key parts were done, let's close it. We can file another issue if we notice another bulk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic Large issue with links to sub-issues
Projects
None yet
Development

No branches or pull requests

4 participants