Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split package in "io.fabric8.kubernetes.api.model" since Quarkus 3.12.0 #41468

Closed
mschorsch opened this issue Jun 26, 2024 · 8 comments · Fixed by #41472
Closed

Split package in "io.fabric8.kubernetes.api.model" since Quarkus 3.12.0 #41468

mschorsch opened this issue Jun 26, 2024 · 8 comments · Fixed by #41472
Labels
area/kubernetes kind/bug Something isn't working
Milestone

Comments

@mschorsch
Copy link
Contributor

Describe the bug

Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in multiple archives: 
- "io.fabric8.kubernetes.api.model" found in [io.fabric8:kubernetes-model-admissionregistration:6.13.0, io.fabric8:kubernetes-model-apiextensions:6.13.0, io.fabric8:kubernetes-model-apps:6.13.0, io.fabric8:kubernetes-model-autoscaling:6.13.0, io.fabric8:kubernetes-model-batch:6.13.0, io.fabric8:kubernetes-model-certificates:6.13.0, io.fabric8:kubernetes-model-coordination:6.13.0, io.fabric8:kubernetes-model-core:6.13.0, io.fabric8:kubernetes-model-discovery:6.13.0, io.fabric8:kubernetes-model-events:6.13.0, io.fabric8:kubernetes-model-extensions:6.13.0, io.fabric8:kubernetes-model-flowcontrol:6.13.0, io.fabric8:kubernetes-model-gatewayapi:6.13.0, io.fabric8:kubernetes-model-metrics:6.13.0, io.fabric8:kubernetes-model-networking:6.13.0, io.fabric8:kubernetes-model-node:6.13.0, io.fabric8:kubernetes-model-policy:6.13.0, io.fabric8:kubernetes-model-rbac:6.13.0, io.fabric8:kubernetes-model-resource:6.13.0, io.fabric8:kubernetes-model-scheduling:6.13.0, io.fabric8:kubernetes-model-storageclass:6.13.0]

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

Linux

Output of java -version

Java 21

Quarkus version or git rev

Quarkus 3.12.0

Build tool (ie. output of mvnw --version or gradlew --version)

Gradle 8.8

Additional information

No response

@mschorsch mschorsch added the kind/bug Something isn't working label Jun 26, 2024
Copy link

quarkus-bot bot commented Jun 26, 2024

/cc @geoand (kubernetes), @iocanel (kubernetes)

@geoand
Copy link
Contributor

geoand commented Jun 26, 2024

cc @manusa

@manusa
Copy link
Contributor

manusa commented Jun 26, 2024

Hi @shawkins
I'm not sure if this is a regression or there were a few split packages still left, do you remember?

Related issues:

@manusa
Copy link
Contributor

manusa commented Jun 26, 2024

OK, it's not a regression, it's a side-effect of:
#40157
That's a fix addressing:
#39300

As far as I can tell, the issue is that all model packages contain the two KubeSchema and Validation classes at io.fabric8.kubernetes.api.model.

@gsmet
Copy link
Member

gsmet commented Jun 26, 2024

We should revert this patch then.

@manusa
Copy link
Contributor

manusa commented Jun 26, 2024

We should be able to address this for version 7, but that of course bears the (future, once released) discussion on how and when to bump Kubernetes Client from 6 to 7.

@gsmet
Copy link
Member

gsmet commented Jun 26, 2024

I created #41472 .

Next time, let's make sure to test this scenario before dropping the ignore rules. Thanks!

@manusa
Copy link
Contributor

manusa commented Jun 26, 2024

I created #41472 .

Thanks

@gsmet gsmet closed this as completed in 3413fa5 Jun 27, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 27, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jul 1, 2024
gsmet added a commit to gsmet/quarkus that referenced this issue Jul 1, 2024
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
danielsoro pushed a commit to danielsoro/quarkus that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants