Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clashing package names in trigger model dependencies #5113

Closed
ggallen opened this issue May 9, 2023 · 1 comment · Fixed by #5346
Closed

Clashing package names in trigger model dependencies #5113

ggallen opened this issue May 9, 2023 · 1 comment · Fixed by #5346
Assignees
Labels
component/extensions Deals with the extensions
Milestone

Comments

@ggallen
Copy link

ggallen commented May 9, 2023

Describe the bug

I am seeing this warning when compiling my application:

WARNING] [io.quarkus.arc.deployment.SplitPackageProcessor] Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in multiple archives: 
 "io.fabric8.tekton.triggers.internal.knative.pkg.apis.duck.v1" found in [io.fabric8:tekton-model-triggers-v1alpha1::jar, io.fabric8:tekton-model-triggers-v1beta1::jar]
 "io.fabric8.tekton.triggers.internal.knative.pkg.apis" found in [io.fabric8:tekton-model-triggers-v1alpha1::jar, io.fabric8:tekton-model-triggers-v1beta1::jar]

This looks like maybe I am pulling in two dependencies (v1alpha1 and v1beta1), and I should only be pulling in one?

This seems to be similar to #5000.

Fabric8 Kubernetes Client version

SNAPSHOT

Steps to reproduce

Compile a Quarkus application that uses triggers.

Expected behavior

No warning is generated.

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.25.3@latest

Environment

Linux

Fabric8 Kubernetes Client Logs

No response

Additional context

No response

@manusa manusa added the component/extensions Deals with the extensions label May 16, 2023
@rohanKanojia
Copy link
Member

Instead of generating io.fabric8.tekton.triggers.internal.knative.pkg.apis.duck packages in both v1alpha1 and v1beta1 trigger model generators, maybe we should only generate it in v1alpha1 and make v1beta1 depend on v1alpha1.

Since these structs are originally coming from knative model, we can also make both of these models depend on knative-model and use these structs from there.

@manusa manusa moved this to Planned in Eclipse JKube Jul 19, 2023
@manusa manusa added this to the 6.8.0 milestone Jul 19, 2023
@rohanKanojia rohanKanojia moved this from Planned to In Progress in Eclipse JKube Jul 20, 2023
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jul 20, 2023
…ggers model (fabric8io#5113)

+ Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be
  generating knative duck types that result in split package warning when
  both packages are used together. Use these packages from common
  knative-model dependency rather than generating it.

Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jul 20, 2023
…ggers model (fabric8io#5113)

+ Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be
  generating knative duck types that result in split package warning when
  both packages are used together. Use these packages from common
  knative-model dependency rather than generating it.

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia self-assigned this Jul 20, 2023
@rohanKanojia rohanKanojia moved this from In Progress to Review in Eclipse JKube Jul 21, 2023
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jul 21, 2023
…ggers model (fabric8io#5113)

+ Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be
  generating knative duck types that result in split package warning when
  both packages are used together. Use these packages from common
  knative-model dependency rather than generating it.

Signed-off-by: Rohan Kumar <[email protected]>
manusa pushed a commit that referenced this issue Jul 21, 2023
…ggers model (#5113)

+ Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be
  generating knative duck types that result in split package warning when
  both packages are used together. Use these packages from common
  knative-model dependency rather than generating it.

Signed-off-by: Rohan Kumar <[email protected]>
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/extensions Deals with the extensions
Projects
None yet
3 participants