-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clashing package names in trigger model dependencies #5113
Comments
11 tasks
Instead of generating Since these structs are originally coming from knative model, we can also make both of these models depend on knative-model and use these structs from there. |
11 tasks
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 20, 2023
…ggers model (fabric8io#5113) + Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be generating knative duck types that result in split package warning when both packages are used together. Use these packages from common knative-model dependency rather than generating it. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 20, 2023
…ggers model (fabric8io#5113) + Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be generating knative duck types that result in split package warning when both packages are used together. Use these packages from common knative-model dependency rather than generating it. Signed-off-by: Rohan Kumar <[email protected]>
12 tasks
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 21, 2023
…ggers model (fabric8io#5113) + Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be generating knative duck types that result in split package warning when both packages are used together. Use these packages from common knative-model dependency rather than generating it. Signed-off-by: Rohan Kumar <[email protected]>
manusa
pushed a commit
that referenced
this issue
Jul 21, 2023
…ggers model (#5113) + Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be generating knative duck types that result in split package warning when both packages are used together. Use these packages from common knative-model dependency rather than generating it. Signed-off-by: Rohan Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I am seeing this warning when compiling my application:
This looks like maybe I am pulling in two dependencies (v1alpha1 and v1beta1), and I should only be pulling in one?
This seems to be similar to #5000.
Fabric8 Kubernetes Client version
SNAPSHOT
Steps to reproduce
Compile a Quarkus application that uses triggers.
Expected behavior
No warning is generated.
Runtime
Kubernetes (vanilla)
Kubernetes API Server version
1.25.3@latest
Environment
Linux
Fabric8 Kubernetes Client Logs
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: