-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning that annotation processing is enabled when using JDK 21 in DEV mode and Java files change #37532
Comments
I was able to reproduce this with just the basic sample app with REST endpoint, the default app from https://code.quarkus.io/
|
I am pretty sure we should wait before doing anything about this because @FroMage has some changes in this area |
I merged my changes, but I'm not sure exactly what this issue is about. Could you clarify? |
there is warning (see issue desc) that would be great to avoid |
OK, but, what are the processors that are detected? Should they be running? |
There is at least extension annotation processor |
I don't know what processor is that we're adding.That's why I asked. But if we do want to make sure that we always have one (or more), then we should perhaps enable it via a build item and set it explicitely. Though perhaps if we do this, it would break any builds have require them to be in the classpath. I think that once you set one explicitely, the classpath ones are ignored. Note that we already have an issue to automatically add the Hibernate processor automatically via a build item as well: #29068 |
I agree we should do something about it. I'm not entirely sure which annotation process would be in the dev classpath but there's probably one around. Ideally we should get rid of it if we could. Or if it's necessary, we should enable it explicitly. Maybe @aloubyansky can help to identify the culprit? One easy way out would be to ignore the filter out the warning until we know more about it. If we can't improve the situation, we should probably do that. |
It already appeared twice during the Maven build so we really don't need it to appear every time we restart dev mode. Fixes quarkusio#37532
It already appeared twice during the Maven build so we really don't need it to appear every time we restart dev mode. Fixes quarkusio#37532
So far the only annotation processor I see on the classpath of a simple REST app is |
Doesn't seem to be enough though |
I was wondering if the extension annotation processor could be around in dev mode? |
No, it's not |
There is |
It already appeared twice during the Maven build so we really don't need it to appear every time we restart dev mode. Fixes quarkusio#37532 (cherry picked from commit 00fc046)
*maven <plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<!-- `-proc:only`: Explicitly enable annotation processing. -->
<compilerArgument>-proc:full</compilerArgument>
</configuration>
</plugin> |
Describe the bug
I run Quarkus application with JDK 21 and get warning about enabled annotation processing. My understanding is that this warning could be avoided if annotation processing was explicitly enabled. Found this: https://bugs.openjdk.org/browse/JDK-8314833
Expected behavior
Avoid warning if possible.
Actual behavior
Following warning is logged:
How to Reproduce?
Steps to reproduce the behavior:
git clone [email protected]:michalvavrik/quarkus-startstop.git
cd quarkus-startstop
mvn -V -B -s .github/mvn-settings.xml clean verify -DexcludeTags=product,native,codequarkus -Dgh.actions -Dtest=ArtifactGeneratorTest -f testsuite/
Alternative reproducer:
mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create -DprojectGroupId=my-groupId -DprojectArtifactId=app-generated-skeleton -DprojectVersion=1.0.0-SNAPSHOT -DpackageName=org.my.group -DquarkusRegistryClient=false -DplatformGroupId=io.quarkus -DplatformVersion=999-SNAPSHOT -Dextensions=quarkus-jaxrs-client-reactive,quarkus-resteasy-reactive,quarkus-resteasy-reactive-jackson,quarkus-resteasy-reactive-qute,quarkus-rest-client-reactive,quarkus-rest-client-reactive-jackson,core,hibernate-orm,hibernate-orm-panache,hibernate-validator,jackson,jaxb,jdbc-mysql,jdbc-postgresql,jsonb,jsonp,kafka-client,kubernetes-config,mailer,narayana-jta,oidc,quarkus-quartz,reactive-pg-client,scheduler,spring-boot-properties,smallrye-reactive-streams-operators,spring-data-jpa,spring-di,spring-security,spring-web,undertow,vertx,quarkus-reactive-routes,grpc,infinispan-client,cache,micrometer,micrometer-registry-prometheus,quarkus-openshift-client,quarkus-smallrye-graphql
mvn clean quarkus:dev -Dquarkus.analytics.disabled=true -Dquarkus.hibernate-orm.enabled=false
sed -i 's/Hello/Bye/g' src/main/java/org/my/group/GreetingResource.java
s
Output of
uname -a
orver
Fedora 38
Output of
java -version
OpenJDK Runtime Environment Temurin-21.0.1+12 (build 21.0.1+12-LTS)
Quarkus version or git rev
999-SNAPSHOT, 3.5.x
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.9.3
Additional information
No response
The text was updated successfully, but these errors were encountered: