Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Java baseline to 17 #326

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Dec 1, 2023

Quarkus changed, we need to get Quarkus Startstop ready for 3.7. See also quarkus-qe/quarkus-test-suite#1556.

@michalvavrik michalvavrik requested a review from jedla97 December 1, 2023 14:32
@michalvavrik michalvavrik marked this pull request as draft December 1, 2023 14:53
@jedla97
Copy link
Member

jedla97 commented Dec 4, 2023

@michalvavrik
Copy link
Member Author

@michalvavrik
Copy link
Member Author

I think I get it @jedla97 you tried to say that #327 fixed qute failures, ok, thank you

@michalvavrik michalvavrik force-pushed the feature/move-java-baseline-to-17 branch from a3b864c to 1129281 Compare December 4, 2023 19:49
@michalvavrik
Copy link
Member Author

@michalvavrik
Copy link
Member Author

CodeQuarkusSiteTest tests https://code.quarkus.redhat.com/, hence it only detects 11 and 17.

@rsvoboda
Copy link
Member

rsvoboda commented Dec 4, 2023

CodeQuarkusSiteTest tests https://code.quarkus.redhat.com/, hence it only detects 11 and 17.

That's true in branches, but not in main - see https://github.com/quarkus-qe/quarkus-startstop/blob/main/testsuite/src/it/java/io/quarkus/ts/startstop/utils/Commands.java#L186

@rsvoboda
Copy link
Member

rsvoboda commented Dec 4, 2023

aha, site check, you are correct, my bad.

@michalvavrik
Copy link
Member Author

FYI Run daily CI and it's green https://github.com/quarkus-qe/quarkus-startstop/actions/runs/7088432644

I adjusted PR description. It can take me while, but I will figure every hint eventually!

@michalvavrik
Copy link
Member Author

Error: ArtifactGeneratorTest.manyReactiveExtensionsSetA:412->testRuntime:361 GENERATOR log should not contain error or warning lines that are not whitelisted. See testsuite\target\archived-logs\io.quarkus.ts.startstop.ArtifactGeneratorTest\manyReactiveExtensionsSetA\dev-run.log and check these offending lines:
2023-12-04 19:53:34,749 WARN [io.qua.dep.dev.JavaCompilationProvider] (vert.x-worker-thread-1) Annotation processing is enabled because one or more processors were found

Opened issue quarkusio/quarkus#37532

@michalvavrik michalvavrik force-pushed the feature/move-java-baseline-to-17 branch from 1129281 to fa87971 Compare December 5, 2023 14:36
@michalvavrik michalvavrik marked this pull request as ready for review December 5, 2023 15:00
@michalvavrik
Copy link
Member Author

@jedla97 your turn

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving errors. LGTM! I look and didn't find any other occurrences of java 11 except site which were previously discussed.

@jedla97 jedla97 merged commit 6812e1c into quarkus-qe:main Dec 5, 2023
9 checks passed
@michalvavrik michalvavrik deleted the feature/move-java-baseline-to-17 branch December 5, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants