-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Java baseline to 17 #326
Move Java baseline to 17 #326
Conversation
https://github.com/quarkus-qe/quarkus-startstop/blob/main/testsuite/src/it/java/io/quarkus/ts/startstop/CodeQuarkusSiteTest.java#L111 .. add case for Java 21, I would also remove Java 11 check as it will go away soon https://github.com/quarkus-qe/quarkus-startstop/blob/main/testsuite/src/it/java/io/quarkus/ts/startstop/CodeQuarkusTest.java#L222 ... change it to |
FYI Run daily CI and it's green https://github.com/quarkus-qe/quarkus-startstop/actions/runs/7088432644 |
https://github.com/quarkus-qe/quarkus-startstop/actions/runs/7088432644/job/19290919431 is not targeting Quarkus 999-SNAPSHOT. |
a3b864c
to
1129281
Compare
done, thanks |
CodeQuarkusSiteTest tests https://code.quarkus.redhat.com/, hence it only detects 11 and 17. |
|
aha, site check, you are correct, my bad. |
I adjusted PR description. It can take me while, but I will figure every hint eventually! |
Opened issue quarkusio/quarkus#37532 |
1129281
to
fa87971
Compare
@jedla97 your turn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving errors. LGTM! I look and didn't find any other occurrences of java 11 except site which were previously discussed.
Quarkus changed, we need to get Quarkus Startstop ready for 3.7. See also quarkus-qe/quarkus-test-suite#1556.