GraalVM 24.0/23.1: JPAFunctionalityInGraalITCase.verifyJDKXMLParsersAreIncluded fails

[jerboaa]

Describe the bug

With a latest Graal master (24.0, possibly also 23.1 build) the JPAFunctionalityInGraalITCase.verifyJDKXMLParsersAreIncluded integration test in native fails, no longer finding TransformerFactory in the report. I haven't looked into the details yet.

Error:  io.quarkus.it.jpa.postgresql.JPAFunctionalityInGraalITCase.verifyJDKXMLParsersAreIncluded -- Time elapsed: 0.179 s <<< FAILURE!
org.opentest4j.AssertionFailedError: Type 'javax.xml.transform.TransformerFactory' was not found in the report in target/quarkus-integration-test-jpa-postgresql-withxml-999-SNAPSHOT-native-image-source-jar/reports/used_classes_quarkus-integration-test-jpa-postgresql-withxml-999-SNAPSHOT-runner_20230901_021852.txt

See:
https://github.com/graalvm/mandrel/actions/runs/6044323984/job/16403307103#step:12:713

[quarkus-bot]

/cc @Karm (mandrel), @galderz (mandrel), @zakkak (mandrel)

[jerboaa]

Reproduced locally. Seems like the instantiation fails with an error?

$ grep -n TransformerFactory reports/used_classes_quarkus-integration-test-jpa-postgresql-withxml-999-SNAPSHOT-runner_20230904_180113.txt
1165:com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl
6794:javax.xml.transform.TransformerFactoryConfigurationError

/cc @Sanne Any pointers perhaps?

[jerboaa]

Is this known to work with JDK 21?

[zakkak]

The test passes in JVM mode with JDK 21.

Tested with:

./mvnw -pl integration-tests/jpa-postgresql-withxml -Dtest-containers -Dstart-containers -Dnative.surefire.skip -Dformat.skip -Dno-descriptor-tests clean verify

Note that the failing assertion is only for native-image runs though, so testing in JVM mode doesn't say much about it.

[jerboaa]

@zakkak Feel free to debug this on the native side. It looks like I won't be able to before Friday or so.

[zakkak]

The test fails here:

        //And finally verify we included the JDK XML by triggering
        //io.quarkus.jdbc.postgresql.runtime.graal.SQLXLMFeature
        report.assertContains(javax.xml.transform.TransformerFactory.class);

According to the logs SQLXLMFeature is indeed triggered:

Quarkus' automatic feature for GraalVM native images: enabling support for XML processing in the PostgreSQL JDBC driver

Looking for javax.xml.tranform in the used classes I see:

6771:javax.xml.transform.FactoryFinder
6772:javax.xml.transform.FactoryFinder$$Lambda$5a39e679f51666ce1c59d72f375f1ff0b1ecd490
6773:javax.xml.transform.FactoryFinder$$Lambda$5d8bd9c0dbbba726a06e35947adff460f55edd61
6774:javax.xml.transform.FactoryFinder$$Lambda$83d8a7fc5d68c5565f8d97170af17eddbdd633e1
6775:javax.xml.transform.FactoryFinder$$Lambda$f22c466d679458ecf16f7edd78c714b092bbb4e9
6776:javax.xml.transform.FactoryFinder$1
6777:javax.xml.transform.TransformerException
6778:javax.xml.transform.TransformerFactoryConfigurationError
6779:javax.xml.transform.dom.DOMResult
6780:javax.xml.transform.dom.DOMSource
6781:javax.xml.transform.sax.SAXResult
6782:javax.xml.transform.sax.SAXSource
6783:javax.xml.transform.stax.StAXResult
6784:javax.xml.transform.stream.StreamResult
6785:javax.xml.transform.stream.StreamSource

Which doesn't include javax.xml.transform.TransformerFactory as reported by the assertion.

Commenting out the failing assertion the test passes.

[Sanne]

It's possible that my relatively old assertion is a bit fragile, the JDK might have made some improvements in this area
(I didn't check though, sorry I'm away).

Feel free to adapt the test: the purpose was primarily to detect the XML parser would be included in this scenario, as opposed to the other test which verifies that it gets excluded when we don't need it.

[zakkak]

Interestingly, despite javax.xml.transform.TransformerFactory not appearing in the used classes report, when compiling with debug symbols generation enabled the said class is present in the debug info, as is its newInstance method. 👀

[zakkak]

Apparently newInstance is pretty trivial and is getting inlined.

    public static TransformerFactory newInstance()
        throws TransformerFactoryConfigurationError {

        return FactoryFinder.find(
            /* The default property name according to the JAXP spec */
            TransformerFactory.class,
            /* The fallback implementation class name, XSLTC */
            "com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl");
    }

Passing -H:-InlineBeforeAnalysis makes the test pass again.

I suggest checking for com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl instead of javax.xml.transform.TransformerFactory. WDYT?