Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Method handle substitutions fix #561

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Sep 7, 2023

These two fixes got cherry-picked from upstream oracle#7262 which we need to fix several quarkus integration tests.

Closes: #559

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 7, 2023
@zakkak zakkak added the backport label Sep 7, 2023
@zakkak zakkak added this to the 23.1.0.0-Final milestone Sep 7, 2023
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest merging it for testing purposes and if upstream decides to backport the fix as well we can drop it with a rebase (or just let it be).

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 7, 2023

Thanks for the review. Will do. I'll wait for CI to finish before I merge.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 7, 2023

The remaining IT Data 5 failure is: quarkusio/quarkus#35676. Mandrel IT tests are mostly the experimental flags warnings dealt elsewhere.

@zakkak
Copy link
Collaborator

zakkak commented Sep 13, 2023

The upstream PR has been backported so I am rebasing mandrel/23.1 and dropping this change.

@zakkak zakkak removed the backport label Sep 13, 2023
@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 13, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[23.1] Several Quarkus native IT tests fail due to new MethodHandle substitutions
3 participants