-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should set app.kubernetes.io/managed-by=quarkus
when we generate deploy schemas
#30572
Labels
Milestone
Comments
I recall wanting to add it to dekorate. Don't recall if we did. Regardless, we should add it something like this for quarkus. |
I'll add it |
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Jan 24, 2023
#30573 should take care of it |
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Jan 24, 2023
geoand
added a commit
that referenced
this issue
Jan 24, 2023
Introduce app.kubernetes.io/managed-by label to k8s manifest generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
in https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ is documented that
app.kubernetes.io/managed-by
should be set to the app that setup the deployment, i.e.helm
we should set it to
quarkus
to separate it from hand edited deployments.Implementation ideas
No response
The text was updated successfully, but these errors were encountered: