Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should set app.kubernetes.io/managed-by=quarkus when we generate deploy schemas #30572

Closed
maxandersen opened this issue Jan 24, 2023 · 5 comments · Fixed by #30573
Closed

should set app.kubernetes.io/managed-by=quarkus when we generate deploy schemas #30572

maxandersen opened this issue Jan 24, 2023 · 5 comments · Fixed by #30573
Labels
Milestone

Comments

@maxandersen
Copy link
Member

Description

in https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ is documented that app.kubernetes.io/managed-by should be set to the app that setup the deployment, i.e. helm

we should set it to quarkus to separate it from hand edited deployments.

Implementation ideas

No response

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 24, 2023

/cc @Sgitario (kubernetes), @geoand (kubernetes), @iocanel (kubernetes)

@geoand
Copy link
Contributor

geoand commented Jan 24, 2023

Does Dekorate have any support for this @iocanel, @Sgitario ? Or should we just add this to the Quarkus extension?

@iocanel
Copy link
Contributor

iocanel commented Jan 24, 2023

I recall wanting to add it to dekorate. Don't recall if we did. Regardless, we should add it something like this for quarkus.

@geoand
Copy link
Contributor

geoand commented Jan 24, 2023

I'll add it

@geoand
Copy link
Contributor

geoand commented Jan 24, 2023

#30573 should take care of it

geoand added a commit that referenced this issue Jan 24, 2023
Introduce app.kubernetes.io/managed-by label to k8s manifest generation
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants