Introduce app.kubernetes.io/managed-by label to k8s manifest generation

Closes: quarkusio#30572
geoand · Jan 24, 2023 · 3f3e0c8 · 3f3e0c8
1 parent d0658da
commit 3f3e0c8
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 2 deletions.
diff --git a/...ns/kubernetes/kind/deployment/src/main/java/io/quarkus/kind/deployment/KindProcessor.java b/...ns/kubernetes/kind/deployment/src/main/java/io/quarkus/kind/deployment/KindProcessor.java
@@ -77,6 +77,7 @@ public void createLabels(KubernetesConfig config, BuildProducer<KubernetesLabelB
             labels.produce(new KubernetesLabelBuildItem(k, v, KIND));
             imageLabels.produce(new ContainerImageLabelBuildItem(k, v));
         });
+        labels.produce(new KubernetesLabelBuildItem(KubernetesLabelBuildItem.CommonLabels.MANAGED_BY, "quarkus", KIND));
     }
 
     @BuildStep

diff --git a/...ions/kubernetes/spi/src/main/java/io/quarkus/kubernetes/spi/KubernetesLabelBuildItem.java b/...ions/kubernetes/spi/src/main/java/io/quarkus/kubernetes/spi/KubernetesLabelBuildItem.java
@@ -25,4 +25,9 @@ public String getValue() {
     public String getTarget() {
         return this.target;
     }
+
+    public static class CommonLabels {
+
+        public static final String MANAGED_BY = "app.kubernetes.io/managed-by";
+    }
 }
diff --git a/...vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/OpenshiftProcessor.java b/...vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/OpenshiftProcessor.java
@@ -124,6 +124,7 @@ public void createLabels(OpenshiftConfig config, BuildProducer<KubernetesLabelBu
             labels.produce(new KubernetesLabelBuildItem(k, v, OPENSHIFT));
             imageLabels.produce(new ContainerImageLabelBuildItem(k, v));
         });
+        labels.produce(new KubernetesLabelBuildItem(KubernetesLabelBuildItem.CommonLabels.MANAGED_BY, "quarkus", OPENSHIFT));
     }
 
     @BuildStep

diff --git a/...deployment/src/main/java/io/quarkus/kubernetes/deployment/VanillaKubernetesProcessor.java b/...deployment/src/main/java/io/quarkus/kubernetes/deployment/VanillaKubernetesProcessor.java
@@ -103,6 +103,7 @@ public void createLabels(KubernetesConfig config, BuildProducer<KubernetesLabelB
             labels.produce(new KubernetesLabelBuildItem(k, v, KUBERNETES));
             imageLabels.produce(new ContainerImageLabelBuildItem(k, v));
         });
+        labels.produce(new KubernetesLabelBuildItem(KubernetesLabelBuildItem.CommonLabels.MANAGED_BY, "quarkus", KUBERNETES));
     }
 
     @BuildStep

diff --git a/...etes/quarkus-standard-way/src/test/java/io/quarkus/it/kubernetes/BasicKubernetesTest.java b/...etes/quarkus-standard-way/src/test/java/io/quarkus/it/kubernetes/BasicKubernetesTest.java
@@ -70,7 +70,8 @@ public void assertGeneratedResources() throws IOException {
             assertThat(d.getSpec()).satisfies(deploymentSpec -> {
                 assertThat(deploymentSpec.getSelector()).isNotNull().satisfies(labelSelector -> {
                     assertThat(labelSelector.getMatchLabels()).containsOnly(entry("app.kubernetes.io/name", "basic"),
-                            entry("app.kubernetes.io/version", "0.1-SNAPSHOT"));
+                            entry("app.kubernetes.io/version", "0.1-SNAPSHOT"),
+                            entry("app.kubernetes.io/managed-by", "quarkus"));
                 });
 
                 assertThat(deploymentSpec.getTemplate()).satisfies(t -> {

diff --git a/...netes/quarkus-standard-way/src/test/java/io/quarkus/it/kubernetes/BasicOpenshiftTest.java b/...netes/quarkus-standard-way/src/test/java/io/quarkus/it/kubernetes/BasicOpenshiftTest.java
@@ -50,7 +50,7 @@ public void assertGeneratedResources() throws IOException {
             // spec assertions
             assertThat(deployment.getSpec().getReplicas()).isEqualTo(1);
             assertThat(deployment.getSpec().getSelector()).containsOnly(entry("app.kubernetes.io/name", "basic-openshift"),
-                    entry("app.kubernetes.io/version", "0.1-SNAPSHOT"));
+                    entry("app.kubernetes.io/version", "0.1-SNAPSHOT"), entry("app.kubernetes.io/managed-by", "quarkus"));
 
             // containers assertions
             assertThat(deployment.getSpec().getTemplate().getSpec().getContainers()).satisfiesExactly(container -> {