Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWT integration tests: Native: False positives on systems with older libs (fontconfig ?) #22652

Closed
Karm opened this issue Jan 5, 2022 · 3 comments · Fixed by #22755
Closed
Assignees
Labels
area/mandrel kind/bug Something isn't working
Milestone

Comments

@Karm
Copy link
Member

Karm commented Jan 5, 2022

Describe the bug

I came across JDK x Mandrel portable builds (regardless of Mandrel version, both 21.2, 21.3 and 22.0) that pass Quarkus AWT tests on RHEL 9 ✔️ , but fail on RHEL 8 ❌ :

TIFF: Wrong pixel at 275x199. Expected: [255,0,0,255] Actual: [171,37,162,255] ==> expected: <true> but was: <false>
PNG:  Wrong pixel at 275x199. Expected: [255,0,0,255] Actual: [171,37,162,255] ==> expected: <true> but was: <false>
JPG:  Wrong pixel at 275x199. Expected: [254,2,0,0]   Actual: [174,36,157,0]   ==> expected: <true> but was: <false>
BMP:  Wrong pixel at 275x199. Expected: [255,0,0,0]   Actual: [171,37,162,0]   ==> expected: <true> but was: <false>

The test was looking for an edge of a character rendered with a specific font.

This might come down to a different native library version being used (fonts?) and needs attention.

I will either attend to the issue on the Mandrel side or adjust the AWT test suite to be more forgiving than it already is with thresholding expected pixel values.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@Karm Karm added the kind/bug Something isn't working label Jan 5, 2022
@Karm Karm self-assigned this Jan 5, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 5, 2022

/cc @galderz, @zakkak

@Karm
Copy link
Member Author

Karm commented Jan 7, 2022

difference_animation

The animation shows the difference. The two top left texts are rendered with font embedded in the test suite whereas the rest of the text is rendered using default fonts either brought with the JDK or present in the system. I cannot reproduce it on a stock, clean install of RHEL 8.5. It looks the same as it does on modern Fedora, Centos 8 Stream, Ubuntu (including GitHub Actions instances). It is just a particular RHEL 8 setup that renders a different image. I will dig deeper and modify the TS to run everywhere as this is a false positive.

@zakkak FYI to see the nice picture :-D

@Karm
Copy link
Member Author

Karm commented Jan 9, 2022

The root cause was different system fonts, not libraries. Solved in #22755

Karm added a commit to Karm/quarkus that referenced this issue Jan 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mandrel kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant