Quarkus kubernetes sidecars configs do not work

[vishalgoel1988]

Describe the bug
Hi,

I am trying to generate sidecar configs using quarkus application.properties. I have below in my application.properties.

quarkus.kubernetes.sidecars.abc.image=def/abc
quarkus.kubernetes.sidecars.abc.ports[0].containerPort=3000
quarkus.kubernetes.sidecars.abc.arguments[0]=--config=/etc/abc/abc.conf
quarkus.kubernetes.sidecars.abc.mount[0].path=/etc/abc

It is supposed to configure abc sidecontainer in kubernetes.yml. But it is not. Main app container is correctly there along with other manifests (e.g. Service, ServiceAccount etc.) in the kubernetes.yml
Is there any issue with my properties? or it is not supported in Quarkus.

Reference:
https://quarkus.io/guides/deploying-to-kubernetes

Expected behavior
Sidecar container should be created in kubernetes.yml

Actual behavior
No sidecar container is created in kubernetes.yml

To Reproduce
Steps to reproduce the behavior:

1. Copy below configs in application.properties of a quarkus kubernetes project

quarkus.kubernetes.sidecars.abc.image=def/abc
quarkus.kubernetes.sidecars.abc.ports[0].containerPort=3000
quarkus.kubernetes.sidecars.abc.arguments[0]=--config=/etc/abc/abc.conf
quarkus.kubernetes.sidecars.abc.mount[0].path=/etc/abc

2.Build the project

Configuration

quarkus.kubernetes.sidecars.abc.image=def/abc
quarkus.kubernetes.sidecars.abc.ports[0].containerPort=3000
quarkus.kubernetes.sidecars.abc.arguments[0]=--config=/etc/abc/abc.conf
quarkus.kubernetes.sidecars.abc.mount[0].path=/etc/abc

Screenshots
(If applicable, add screenshots to help explain your problem.)

Environment (please complete the following information):

• Output of uname -a or ver:
• Output of java -version:
• GraalVM version (if different from Java):
• Quarkus version or git rev:
• Build tool (ie. output of mvnw --version or gradlew --version):

Additional context
(Add any other context about the problem here.)

[geoand]

Hi,

I don't think we support sidecar generation, may I ask what made you think we do?

[vishalgoel1988]

Hi,

Please check reference in my question: https://quarkus.io/guides/deploying-to-kubernetes
This has configs for sidecar deployment:

quarkus.kubernetes.sidecars | Map<String, Container>

[geoand]

That looks like a bug in the documentation then. @iocanel I assume it was added by accident?

[vishalgoel1988]

Just curious that dekorate provides the sidecar functionality. Should it be not included in quarkus automatically?

[geoand]

Not all things from dekorate work (nor do we want all of them to). We pick and choose what we want. In this case, I think we just overlooked the sidecar configuration

…

On Fri, Jun 26, 2020, 22:24 vishalgoel1988 ***@***.***> wrote: Just curious that dekorate provides the sidecar functionality. Should it be not included in quarkus automatically? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10308 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBMDPZSSL2WTXLQIOTFOFTRYTYX5ANCNFSM4OJM3VQQ> .

[vishalgoel1988]

Ok.

Is it possible to have it in next release. This is quite helpful.

[geoand]

I am not sure we can make it for 1.6, most likely it will be 1.7

…

On Fri, Jun 26, 2020, 22:31 vishalgoel1988 ***@***.***> wrote: Ok. Is it possible to have it in next release. This is quite helpful. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10308 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBMDP7BQ44FRIWTI23EMGTRYTZPJANCNFSM4OJM3VQQ> .

[vishalgoel1988]

Ok.
Is there any expected release date for 1.7?

[geoand]

Should be early August if all goes well

…

On Fri, Jun 26, 2020, 22:39 vishalgoel1988 ***@***.***> wrote: Ok. Is there any expected release date for 1.7? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10308 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBMDP273HLZGTQFP2P7OKLRYT2O7ANCNFSM4OJM3VQQ> .

[geoand]

What's more, the properties aren't even using the proper syntax.
@iocanel this should just be a matter of defining the configuration and adding the proper decorators right? If possible, I would like to fix this in time for 1.6 since we already have it in the docs.
I just need your confirmation that there is nothing more to it before starting to look into it.

[vishalgoel1988]

Hi @geoand
Can you please help in correcting the syntax?

[geoand]

There is no correct syntax yet, because there is no dedicated configuration support for sidecars. But I assume it will be similar to what we have with env vars

[vishalgoel1988]

Ok. It would be really helpful if we can get sidecars configs in 1.6
Also, type "Mount" (which is required for sidecar "Container" type) has missing "name" property (at least in documentation).

Thanks.

[geoand]

@vishalgoel1988 the issue should be fixed in #10333.

See https://github.com/geoand/quarkus/blob/ae5485672bddfe66f710dfd766ee80dfb1ef02c8/integration-tests/kubernetes/quarkus-standard-way/src/test/resources/kubernetes-with-sidecar-and-jib.properties to see what the proper use of sidecars should be (after the PR has been merged).

[vishalgoel1988]

Thanks @geoand
One little question. How can we give multiple arguments? by comma separated?

quarkus.kubernetes.sidecars.sc.arguments=-a,-b

[geoand]

quarkus.kubernetes.sidecars.sc.arguments=-a,-b

Exactly