Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with sidecar probes #14795

Closed
shawkins opened this issue Feb 3, 2021 · 6 comments · Fixed by #15140
Closed

Issues with sidecar probes #14795

shawkins opened this issue Feb 3, 2021 · 6 comments · Fixed by #15140
Assignees
Labels
area/kubernetes kind/bug Something isn't working
Milestone

Comments

@shawkins
Copy link
Contributor

shawkins commented Feb 3, 2021

Describe the bug
There are several problems with attempting to configure sidecar probes through the application.properties. First any probe properties such as http-action-path, seem to be ignored. Second the probe port is set to the value of quarkus.http.port - which is not correct for the sidecar container.

Expected behavior
Using the properties:
quarkus.kubernetes.sidecars.x.liveness-probe.http-action-path=/q/health/ready
quarkus.kubernetes.sidecars.x.ports.http.container-port=9090

It is expected that the generated target/kubernetes/kubernetes.yml sidecar container would contain:

        livenessProbe:
          failureThreshold: 3
          httpGet:
            path: "/q/health/ready"
            port: 9090

Actual behavior
Instead the generated kubernetes.yml contains an empty path and the quarkus.http.port for the port:

        livenessProbe:
          failureThreshold: 3
          httpGet:
            path: ""
            port: 8080

Environment:
Quarkus version 1.11.0.Final
Maven info:
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Java version: 11.0.9.1, vendor: Red Hat, Inc., runtime: /usr/lib/jvm/java-11-openjdk-11.0.9.11-9.fc32.x86_64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.10.7-100.fc32.x86_64", arch: "amd64", family: "unix"

See also an earlier issue: #10308

@shawkins shawkins added the kind/bug Something isn't working label Feb 3, 2021
@ghost ghost added the area/kubernetes label Feb 3, 2021
@ghost
Copy link

ghost commented Feb 3, 2021

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Feb 3, 2021

cc @iocanel

@FroMage
Copy link
Member

FroMage commented Feb 4, 2021

@iocanel if you don't have time, perhaps I can take a look?

@FroMage FroMage self-assigned this Feb 9, 2021
@FroMage
Copy link
Member

FroMage commented Feb 9, 2021

Actually this is less urgent now, so I'll switch to a more urgent issue

@FroMage FroMage removed their assignment Feb 9, 2021
@gsmet
Copy link
Member

gsmet commented Feb 15, 2021

Ping @iocanel .

@iocanel iocanel self-assigned this Feb 15, 2021
@iocanel
Copy link
Contributor

iocanel commented Feb 15, 2021

I must have done something weird with my notifications settings and I keep on missing mentions. Feel free to directly assign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants