Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit automatic module name #20

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

benkard
Copy link
Contributor

@benkard benkard commented Nov 20, 2022

Adds an explicit automatic module name of io.quarkus.security, which matches the root package name.

This is a breaking change for modular applications, but not for users that use Quarkus on the class path.

Fixes quarkusio/quarkus#25795
Fixes quarkusio/quarkus#40417

See also: quarkusio/quarkus#29370

@benkard benkard force-pushed the feature/automatic-module-names branch from 41ad3c8 to 0d54908 Compare November 20, 2022 19:28
@benkard benkard changed the title Add explicit automatic module path Add explicit automatic module name Nov 21, 2022
@benkard benkard force-pushed the feature/automatic-module-names branch from 0d54908 to 452bcf4 Compare November 21, 2022 05:59
@benkard benkard marked this pull request as ready for review November 22, 2022 05:25
@gsmet gsmet force-pushed the feature/automatic-module-names branch from 452bcf4 to 8a54907 Compare June 6, 2024 15:55
Adds an explicit automatic module name of io.quarkus.security, which
matches the root package name.

Fixes quarkusio/quarkus#25795.
@gsmet gsmet force-pushed the feature/automatic-module-names branch from 8a54907 to 39654bf Compare June 6, 2024 16:00
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long and thanks for the PR!

I adjusted the name to io.quarkus.security.api so that we make sure it doesn't conflict with the names we might choose for Quarkus core artifacts in the future.

@sberyozkin
Copy link
Member

More recent Quarkus issue is 40417

@gsmet gsmet merged commit 7319432 into quarkusio:main Jun 6, 2024
3 checks passed
@gsmet
Copy link
Member

gsmet commented Jun 6, 2024

I released 2.1.0 just now and we will update in Quarkus when it hits Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants