Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quarkus-security jar names unique so they do not conflict with java auto modules #40417

Closed
diversit opened this issue May 2, 2024 · 2 comments · Fixed by quarkusio/quarkus-security#20
Assignees
Labels
area/security kind/enhancement New feature or request

Comments

@diversit
Copy link

diversit commented May 2, 2024

Description

When using the dependency io.quarkus:quarkus-security this also adds a dependency on io.quarkus.security:quarkus-security.

The names of the jar files of both dependencies are identical.
Since Quarkus still has not defined a module-info, when using Java Modules, the module names are created automatically based on the jar name.
Adding requires quarkus.security does not work since it matches both jars.
This results in these compile errors:

package io.quarkus.security.identity does not exist
cannot find symbol
[ERROR]   symbol:   class SecurityIdentity
[ERROR]   location: class my.pkg.MyHttpSecurityPolicy

Implementation ideas

Please rename one of the security packages to solve this name conflict since this now means we can no longer use Java Modules when using Quarkus Security.

@diversit diversit added the kind/enhancement New feature or request label May 2, 2024
Copy link

quarkus-bot bot commented May 2, 2024

/cc @sberyozkin (security)

@sberyozkin
Copy link
Member

sberyozkin commented May 3, 2024

I'll open a PR renaming io.quarkus.security:quarkus-security to io.quarkus.security:quarkus-security-api as agreed awhile back at #25795 with @stuartwdouglas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security kind/enhancement New feature or request
Projects
None yet
2 participants