-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.7] Bulk - Backport 2.7 - part 2 #703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 708be0e)
Test dependency injection using ArC `@All` with `List`. See also quarkusio/quarkus#25784. (cherry picked from commit ad4f60e)
Currently traces are filtered by "operationName" which is not valid filter parameter and operations are not filtered by this. That causes problem in OpenShift where there are other calls (other operations with different names, e.g. "HTTP GET" - probably probe check). Problem can be easily reproduced locally on GraphQLTelemetryIT when you call GET to '/' couple of times, which leads to test failure. (cherry picked from commit 815c398)
(cherry picked from commit b5ad765)
(cherry picked from commit fb187b9)
(cherry picked from commit 387a090)
(cherry picked from commit c1b87bd)
(cherry picked from commit b88a1cc)
(cherry picked from commit d2d335f)
(cherry picked from commit 5a19802)
(cherry picked from commit 1f12f30)
michalvavrik
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please select the relevant options.
Checklist: