Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] Bulk - Backport 2.7 - part 2 #703

Merged
merged 11 commits into from
Jun 10, 2022
Merged

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Jun 10, 2022

Summary

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

rsvoboda and others added 11 commits June 10, 2022 09:18
Test dependency injection using ArC `@All` with `List`.
See also quarkusio/quarkus#25784.

(cherry picked from commit ad4f60e)
Currently traces are filtered by "operationName" which is not valid filter parameter and operations are not filtered by this. That causes problem in OpenShift where there are other calls (other operations with different names, e.g. "HTTP GET" - probably probe check). Problem can be easily reproduced locally on GraphQLTelemetryIT when you call GET to '/' couple of times, which leads to test failure.

(cherry picked from commit 815c398)
@pjgg pjgg requested a review from michalvavrik June 10, 2022 07:20
@pjgg pjgg changed the title [2.7] Backport 2.7 [2.7] Bulk - Backport 2.7 - part 2 Jun 10, 2022
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit 9f34cfc into quarkus-qe:2.7 Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants