Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no NPE is thrown when using RestClient with Micrometer disabled #698

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Ensure no NPE is thrown when using RestClient with Micrometer disabled #698

merged 1 commit into from
Jun 8, 2022

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Jun 8, 2022

Ensure no NPE is thrown when using RestClient with Micrometer disabled

relates to quarkusio/quarkus@f485a52

FAIL: mvn clean verify -f http/rest-client -Dquarkus.platform.version=2.7.5.Final
PASS: mvn clean verify -f http/rest-client -Dquarkus.platform.version=2.7.6.Final

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda rsvoboda added the triage/backport-2.7? It needs to backport changes to branch 2.7 label Jun 8, 2022
@rsvoboda rsvoboda requested a review from michalvavrik June 8, 2022 11:46
michalvavrik
michalvavrik approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit 0d5d35a into quarkus-qe:main Jun 8, 2022
@pjgg pjgg mentioned this pull request Jun 10, 2022
Merged
8 tasks
@pjgg pjgg added this to the 2.7 milestone Jun 13, 2022
@pjgg pjgg removed the triage/backport-2.7? It needs to backport changes to branch 2.7 label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@rsvoboda @michalvavrik @pjgg