QUARKUS-1676 Add tests for 'MAIF - mTLS with OIDC Server' #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjgg
suggested changes
Apr 19, 2022
There was a problem hiding this comment.
Missing add a reference in project README.md, that explains what this module does. You could use as an example some of the previous modules ex: security/basic
Some of the test/resources certificates already exist in main/resource folder, so you don't need to duplicate it, just use main/resource certificates.
...mutual-tls/src/test/java/io/quarkus/ts/security/oidcclient/mtls/AuthenticationTestSuite.java
Outdated
Show resolved
Hide resolved
...mutual-tls/src/test/java/io/quarkus/ts/security/oidcclient/mtls/AuthenticationTestSuite.java
Outdated
Show resolved
Hide resolved
...utual-tls/src/test/java/io/quarkus/ts/security/oidcclient/mtls/MutualTlsKeycloakService.java
Show resolved
Hide resolved
...mutual-tls/src/test/java/io/quarkus/ts/security/oidcclient/mtls/AuthenticationTestSuite.java
Outdated
Show resolved
Hide resolved
...utual-tls/src/test/java/io/quarkus/ts/security/oidcclient/mtls/MutualTlsKeycloakService.java
Outdated
Show resolved
Hide resolved
security/oidc-client-mutual-tls/src/test/resources/openshift-rh-sso-deployment-template.yml
Show resolved
Hide resolved
This commit add tests for a mutual TLS with OIDC as suggested by [a test plan](quarkus-qe/quarkus-test-plans#76). There are tests for JKS/PKCS12 keystore types, a fail test when a keystore file is completely missing, test with Keycloak and RH SSO 7.3/7.5 in role of a OIDC server and test with keystore file whose file type can't be detected by a file extension. refactor according to review comments and add a new test
|
Hello @pjgg , thank you for the review. I added a reference to BR, |
pjgg
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add tests for a mutual TLS with OIDC as suggested by a test plan. There are tests for JKS/PKCS12 keystore types, a fail test when a keystore file is completely missing, test with Keycloak and RH SSO 7.3/7.5 in role of a OIDC server and test with keystore file whose file type can't be detected by a file extension.