Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUARKUS-1676 mTLS with OIDC Server #76

Merged
merged 1 commit into from
Apr 21, 2022
Merged

QUARKUS-1676 mTLS with OIDC Server #76

merged 1 commit into from
Apr 21, 2022

Conversation

michalvavrik
Copy link
Member

Provides a test plan for QUARKUS-1676

@mjurc mjurc self-requested a review April 12, 2022 14:14
mjurc
mjurc requested changes Apr 12, 2022
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Also, please squash commits - there should be one commit for one logical unit of work.

QUARKUS-1676.md Outdated Show resolved Hide resolved
QUARKUS-1676.md Outdated Show resolved Hide resolved
QUARKUS-1676.md Outdated Show resolved Hide resolved
QUARKUS-1676.md Outdated Show resolved Hide resolved
QUARKUS-1676.md Show resolved Hide resolved
QUARKUS-1676.md Outdated Show resolved Hide resolved
@michalvavrik
Copy link
Member Author

Thanks for a hint, commits squashed.

@michalvavrik michalvavrik requested a review from mjurc April 18, 2022 22:03
@michalvavrik michalvavrik mentioned this pull request Apr 18, 2022
Merged
mjurc
mjurc requested changes Apr 20, 2022
View reviewed changes
QUARKUS-1676.md Outdated Show resolved Hide resolved
@michalvavrik
Copy link
Member Author

I enhanced information on resources requirements.

@michalvavrik michalvavrik requested a review from mjurc April 21, 2022 09:49
mjurc
mjurc approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjurc mjurc merged commit 1b2a650 into quarkus-qe:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

Assignees

@michalvavrik michalvavrik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @mjurc