Dont configure HTTPS in security Vert.X JWT tests #1976
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses correct point raised here #1973 (comment)
Context: ATM we always set CA cert to truststore (which is correct place) even when
configureTruststore=false
. My logic was that you rarely need PEM key/cert without CA cert. But we need to tweak CertificateBuilder and correct Javadoc to explain why is CA cert set. Or agree to explicitly requireconfigureTruststore=true
.Whatever we agree on, my thinking is that this option has no negative impact for this scenario while previous configures HTTPS.
Please select the relevant options.
run tests
phrase in comment)Checklist: