Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont configure HTTPS in security Vert.X JWT tests #1976

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

michalvavrik
Copy link
Member

Summary

Addresses correct point raised here #1973 (comment)

Context: ATM we always set CA cert to truststore (which is correct place) even when configureTruststore=false. My logic was that you rarely need PEM key/cert without CA cert. But we need to tweak CertificateBuilder and correct Javadoc to explain why is CA cert set. Or agree to explicitly require configureTruststore=true.

Whatever we agree on, my thinking is that this option has no negative impact for this scenario while previous configures HTTPS.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy
Copy link
Contributor

run tests

Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fedinskiy fedinskiy merged commit cad00bd into quarkus-qe:main Sep 5, 2024
10 checks passed
@michalvavrik michalvavrik deleted the feature/fix-http-server branch September 5, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants