Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump quarkus.qe.framework.version from 1.6.0.Beta1 to 1.6.0.Beta2 #1973

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2024

Bumps quarkus.qe.framework.version from 1.6.0.Beta1 to 1.6.0.Beta2.
Updates io.quarkus.qe:quarkus-test-parent from 1.6.0.Beta1 to 1.6.0.Beta2

Commits
  • a560e3d [maven-release-plugin] prepare release 1.6.0.Beta2
  • 7ff07af Release 1.6.0.Beta2
  • 7fd4c34 Autogenerated JaCoCo coverage badge
  • 614b2ec Merge pull request #1277 from michalvavrik/feature/jaeger-tls
  • ba45eef Support Jaeger TLS communication using registry
  • 87b6219 Merge pull request #1276 from michalvavrik/feature/tls-registry-with-strimzi
  • 8d18d28 Merge pull request #1274 from quarkus-qe/dependabot/maven/io.quarkiverse.arte...
  • 1ca8418 Support TLS registry with Kafka Strimzi
  • 9a7ecda Support gRPC TLS communication and TLS registry
  • c40e767 Bump io.quarkiverse.artemis:quarkus-artemis-jms from 3.4.1 to 3.4.2
  • Additional commits viewable in compare view

Updates io.quarkus.qe:quarkus-test-containers from 1.6.0.Beta1 to 1.6.0.Beta2

Commits
  • a560e3d [maven-release-plugin] prepare release 1.6.0.Beta2
  • 7ff07af Release 1.6.0.Beta2
  • 7fd4c34 Autogenerated JaCoCo coverage badge
  • 614b2ec Merge pull request #1277 from michalvavrik/feature/jaeger-tls
  • ba45eef Support Jaeger TLS communication using registry
  • 87b6219 Merge pull request #1276 from michalvavrik/feature/tls-registry-with-strimzi
  • 8d18d28 Merge pull request #1274 from quarkus-qe/dependabot/maven/io.quarkiverse.arte...
  • 1ca8418 Support TLS registry with Kafka Strimzi
  • 9a7ecda Support gRPC TLS communication and TLS registry
  • c40e767 Bump io.quarkiverse.artemis:quarkus-artemis-jms from 3.4.1 to 3.4.2
  • Additional commits viewable in compare view

Updates io.quarkus.qe:quarkus-test-openshift from 1.6.0.Beta1 to 1.6.0.Beta2

Commits
  • a560e3d [maven-release-plugin] prepare release 1.6.0.Beta2
  • 7ff07af Release 1.6.0.Beta2
  • 7fd4c34 Autogenerated JaCoCo coverage badge
  • 614b2ec Merge pull request #1277 from michalvavrik/feature/jaeger-tls
  • ba45eef Support Jaeger TLS communication using registry
  • 87b6219 Merge pull request #1276 from michalvavrik/feature/tls-registry-with-strimzi
  • 8d18d28 Merge pull request #1274 from quarkus-qe/dependabot/maven/io.quarkiverse.arte...
  • 1ca8418 Support TLS registry with Kafka Strimzi
  • 9a7ecda Support gRPC TLS communication and TLS registry
  • c40e767 Bump io.quarkiverse.artemis:quarkus-artemis-jms from 3.4.1 to 3.4.2
  • Additional commits viewable in compare view

Updates io.quarkus.qe:quarkus-test-core from 1.6.0.Beta1 to 1.6.0.Beta2

Commits
  • a560e3d [maven-release-plugin] prepare release 1.6.0.Beta2
  • 7ff07af Release 1.6.0.Beta2
  • 7fd4c34 Autogenerated JaCoCo coverage badge
  • 614b2ec Merge pull request #1277 from michalvavrik/feature/jaeger-tls
  • ba45eef Support Jaeger TLS communication using registry
  • 87b6219 Merge pull request #1276 from michalvavrik/feature/tls-registry-with-strimzi
  • 8d18d28 Merge pull request #1274 from quarkus-qe/dependabot/maven/io.quarkiverse.arte...
  • 1ca8418 Support TLS registry with Kafka Strimzi
  • 9a7ecda Support gRPC TLS communication and TLS registry
  • c40e767 Bump io.quarkiverse.artemis:quarkus-artemis-jms from 3.4.1 to 3.4.2
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `quarkus.qe.framework.version` from 1.6.0.Beta1 to 1.6.0.Beta2.

Updates `io.quarkus.qe:quarkus-test-parent` from 1.6.0.Beta1 to 1.6.0.Beta2
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.6.0.Beta1...1.6.0.Beta2)

Updates `io.quarkus.qe:quarkus-test-containers` from 1.6.0.Beta1 to 1.6.0.Beta2
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.6.0.Beta1...1.6.0.Beta2)

Updates `io.quarkus.qe:quarkus-test-openshift` from 1.6.0.Beta1 to 1.6.0.Beta2
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.6.0.Beta1...1.6.0.Beta2)

Updates `io.quarkus.qe:quarkus-test-core` from 1.6.0.Beta1 to 1.6.0.Beta2
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.6.0.Beta1...1.6.0.Beta2)

---
updated-dependencies:
- dependency-name: io.quarkus.qe:quarkus-test-parent
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.quarkus.qe:quarkus-test-containers
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: io.quarkus.qe:quarkus-test-openshift
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.quarkus.qe:quarkus-test-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 4, 2024
@michalvavrik
Copy link
Member

This release contains breaking changes, let's work on this together. People and bots! I'll push changes soon.

@michalvavrik michalvavrik self-requested a review September 4, 2024 08:21
@michalvavrik michalvavrik force-pushed the dependabot/maven/quarkus.qe.framework.version-1.6.0.Beta2 branch from 40d7c4d to 3d32003 Compare September 4, 2024 08:30
@michalvavrik
Copy link
Member

run tests

@michalvavrik
Copy link
Member

Build fails over podman which is known issues. LGTM mergin. Nice cooperation @dependabot !

@michalvavrik michalvavrik merged commit 30ee7f5 into main Sep 4, 2024
8 of 10 checks passed
@michalvavrik michalvavrik deleted the dependabot/maven/quarkus.qe.framework.version-1.6.0.Beta2 branch September 4, 2024 12:57
@@ -43,16 +43,16 @@ public abstract class AbstractCommonIT {
static DefaultService redis = new DefaultService().withProperty("ALLOW_EMPTY_PASSWORD", "YES");

@QuarkusApplication(certificates = {
@Certificate(format = Certificate.Format.PEM, prefix = VALID_PEM_PREFIX),
@Certificate(format = Certificate.Format.PEM, prefix = INVALID_PEM_PREFIX)
@Certificate(format = Certificate.Format.PEM, prefix = VALID_PEM_PREFIX, configureHttpServer = true, useTlsRegistry = false),
Copy link
Contributor

@fedinskiy fedinskiy Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalvavrik why do we use configureHttpServer here? This test doesn't use https connection

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intention of my commit is to keep status quo. I don't look what this test does or not, I only wanted to keep previous behavior. So previously this property was implicitly true, now it is not. I would not dare to change functionality in dependabot bump. that is why.

I agree this should be drop it. I'll look into it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by implicitly true I mean these properties were set and the flag didn't exist.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you, "it was like that by default" is fine with me.

For context: without these options the test failed, but I was not sure, if we need to use configureHttpServer or, say, configureTruststore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is because of this stupid condition https://github.com/quarkus-qe/quarkus-test-framework/blob/main/quarkus-test-core/src/main/java/io/quarkus/test/security/certificate/CertificateBuilder.java#L49 I will tweak it in FW but let's not wait for FW PR and release, it could take a while. Workaround this for now: #1976

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certificate generation is not required for OpenShift serving certificates, so I added there condition to run less code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants