Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MySQL container host used in AgroalPoolTest as Windows tests are using remote Docker client #1881

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix MySQL container host used in AgroalPoolTest as Windows tests are using remote Docker client #1881

merged 1 commit into from
Jul 10, 2024

Conversation

michalvavrik
Copy link
Member

Summary

We cannot rely on localhost. This is consequence of my PR #1782 but it only demonstrates when run on our Windows runners that rely on Minikube.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from gtroitsk July 10, 2024 13:10
@gtroitsk gtroitsk merged commit 775ab76 into quarkus-qe:main Jul 10, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-agroal-pool-test-on-windows branch July 10, 2024 13:49
@jedla97 jedla97 added this to the 3.8 milestone Sep 3, 2024
@jedla97 jedla97 mentioned this pull request Sep 3, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtroitsk gtroitsk gtroitsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@michalvavrik @gtroitsk @jedla97