Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and fix MySQL JDBC-based tests in FIPS-enabled environment and correct FIPS-disabling comment on MySQL reactive tests #1782

Merged
merged 1 commit into from
May 3, 2024

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented May 2, 2024

Summary

closes: #756

  • enables MySQL JDBC-based tests as they work with the MySQL connector and database used in 3.8.4 and 999-SNAPSHOT
  • fixes TODO next to MySQL reactive tests
  • AgroalPoolTest didn't work over SA/ECB/OAEPWithSHA-1AndMGF1Padding error (like in Failure during connection to MYSQL on FIPS-compliant host quarkusio/quarkus#32910 but in TC MySQL lib) but that's TC's version of MySQL container, so I switched waiting strategy that works in FIPS-enabled environment as well

I run all enabled tests with RH OpenJDK 17 and Quarkus 999-SNAPSHOT and 3.8.4. The ones with "native" comment I also run in a native mode. The reactive MySQL tests are disabled due to eclipse-vertx/vertx-sql-client#1436. As far as Quarkus goes, we have QUARKUS-4387, which is why I didn't create Quarkus issue (3 issues for one bug seems too much).

CI Failures: The Hibernate Reactive and Transacitonal module also fails in a daily build and I'm only changing jupiter Tag and comment there, that can't cause any failures. I have opened quarkusio/quarkus#40425 for Hibernate Reactive ones.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/mysql-fips-fixes branch from b317195 to bf20f31 Compare May 3, 2024 08:55
@michalvavrik
Copy link
Member Author

michalvavrik commented May 3, 2024

FYI @fedinskiy we also have DEV mode MySQL tests failing in FIPS (e.g. io.quarkus.ts.sqldb.sqlapp.DevModeMysqlIT), but I will handle that next weeks. I'll probably just open Quarkus issue for that and disable them, but I need to investigate properly first. They are not changed in this PR.

@michalvavrik michalvavrik requested a review from fedinskiy May 3, 2024 12:21
@michalvavrik
Copy link
Member Author

CI failures are not related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why scenarios with MYSQL + native mode are failing with FIPS enabled
2 participants