Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for issue in PR 37268. #1622

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Jan 19, 2024

Summary

Add test coverage for quarkusio/quarkus#37268 and issue described in it.
Issue is that ClientRequestFilter is not applied, if ContainerResponseFilter is also present in the same class, because of quarkusio/quarkus#37006.

This PR is similar to #1616 but this test requires the restClient to actually do a request for the client filter to be invoked. For that reason, this new tests is in rest-client-reactive module, where is can do actual requests.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from michalvavrik January 19, 2024 10:30
@mocenas
Copy link
Contributor Author

mocenas commented Jan 19, 2024

run tests

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michalvavrik michalvavrik merged commit 5dce2e5 into quarkus-qe:main Jan 19, 2024
9 checks passed
@michalvavrik michalvavrik added the triage/backport-3.2 RHBQ Ghost LTS release label Jan 19, 2024
@mocenas mocenas deleted the rest_client_test branch January 22, 2024 08:18
@michalvavrik michalvavrik removed the triage/backport-3.2 RHBQ Ghost LTS release label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants