Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for containerResponseFilter issue #1616

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Jan 17, 2024

Summary

Adding test coverage for issue quarkusio/quarkus#31024.

For issue to manifest we need a quarkus app without resteasy dependency. It is probably cleaner and easier to maintain, to have a new module for this, that creating some system to exclude this dependency for some test. It would require a new build of quarkus app anyway, so this approach should not bring any more performance drawbacks.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from rsvoboda January 17, 2024 09:21
@mocenas
Copy link
Contributor Author

mocenas commented Jan 17, 2024

run tests

@michalvavrik
Copy link
Member

@mocenas I've tried it and the exception is not detectable, you were right about logging, let's stick with it.

@mocenas mocenas requested a review from michalvavrik January 18, 2024 15:43
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AFAIC you can merge it or wait for @rsvoboda if he finds a time. Thanks

@michalvavrik
Copy link
Member

Remainder: Whoever merge this must use Squash and merge option.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just realized you need to add note to README about new module. Then it's fine with me.

@mocenas mocenas requested a review from michalvavrik January 19, 2024 08:05
@mocenas
Copy link
Contributor Author

mocenas commented Jan 19, 2024

Sorry, I just realized you need to add note to README about new module. Then it's fine with me.

added

@mocenas mocenas merged commit 09243b3 into quarkus-qe:main Jan 19, 2024
7 checks passed
@mocenas mocenas deleted the rest_caller_test_coverage branch January 19, 2024 09:36
@michalvavrik michalvavrik added the triage/backport-3.2 RHBQ Ghost LTS release label Jan 19, 2024
michalvavrik pushed a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jan 22, 2024
@michalvavrik michalvavrik removed the triage/backport-3.2 RHBQ Ghost LTS release label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants