Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Kafka 3.5 as AMQ operator does not support 3.6 #937

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Use Kafka 3.5 as AMQ operator does not support 3.6 #937

merged 1 commit into from
Oct 26, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Oct 25, 2023 •
edited
Loading

Summary

OperatorOpenShiftAmqStreamsKafkaStreamIT fails as AMQ operator amqstreams.v2.5.1-0 only supports 3.5 and 3.4 so you were right here #925.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik added triage/backport-1.2? Backport to 1.2 branch may be required triage/backport-1.3? Backport to 1.3 branch may be required labels Oct 25, 2023
@michalvavrik
Copy link
Member Author

run tests

mjurc
mjurc approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Can you open this for 1.3.z/1.2.z branches too?

@mjurc mjurc merged commit 3b2097c into quarkus-qe:main Oct 26, 2023
9 checks passed
@michalvavrik michalvavrik deleted the feature/use-kafka-3-5 branch October 26, 2023 07:55
@michalvavrik michalvavrik mentioned this pull request Oct 26, 2023
Merged
11 tasks
This was referenced Nov 22, 2023
Merged
Merged
@michalvavrik michalvavrik removed triage/backport-1.2? Backport to 1.2 branch may be required triage/backport-1.3? Backport to 1.3 branch may be required labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @mjurc