Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unavailable skip-tests-on-windows-in-native profile #867

Merged

Conversation

rsvoboda
Copy link
Member

Summary

Remove unavailable skip-tests-on-windows-in-native profile

Property was removed in 5238f12#diff-5f1afddf2b21f65a58e6aa212e01eb16621165ef2a238d221f8a98dc3f4b4f6bL63

quarkusio/quarkus#27061 is still not resolved, so maybe skip-tests-on-windows-in-native removal in the mentioned commit was not intentional? @michalvavrik

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made mistake when removing the profile (and completely forgot about the linked issue), but let us see if the issue is still there (IMHO we will see in 2-3 days) and if daily build will fail, we can put the profile back.

@michalvavrik michalvavrik merged commit 5ba9e44 into quarkus-qe:main Aug 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants