Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable QuarkusScenario tests automatically when Linux containers are not available but the test requires them #864

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Aug 25, 2023

Summary

Tests are automatically disabled when Linux containers are not available, but the test has managing resource that requires Linux containers. Detecting when Quarkus CLI starts in DEV mode will require additional effort.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/disable-test-when-linux-containers-not-available branch from 13108ed to 2ccaa28 Compare August 25, 2023 13:51
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense and the conditions are correct, as far as I can see from the review.

Can we have some runs with test suite on baremetal with docker/podman, too? Perhaps it would be for the better to try this on OCP jobs also.

@michalvavrik michalvavrik force-pushed the feature/disable-test-when-linux-containers-not-available branch 3 times, most recently from 0f3f6d1 to 1a1ec9a Compare August 25, 2023 20:52
@michalvavrik
Copy link
Member Author

run tests

mjurc
mjurc previously requested changes Aug 28, 2023
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think my last review comment will require changes.

@michalvavrik michalvavrik force-pushed the feature/disable-test-when-linux-containers-not-available branch from afc6616 to 5238f12 Compare August 28, 2023 20:52
@michalvavrik
Copy link
Member Author

run tests

@mjurc
Copy link
Member

mjurc commented Aug 29, 2023

run tests

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Think this looks fine now, although that catch (Exception ex) is kinda nasty.

Let's get the CI run green - it seems that the test clusters had full objectstore after last week.

@michalvavrik
Copy link
Member Author

All green, merging, thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants