-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable QuarkusScenario tests automatically when Linux containers are not available but the test requires them #864
Conversation
13108ed
to
2ccaa28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change makes sense and the conditions are correct, as far as I can see from the review.
Can we have some runs with test suite on baremetal with docker/podman, too? Perhaps it would be for the better to try this on OCP jobs also.
...st/services/execution/conditions/EnableOnLinuxContainersWhenContainersRequiredCondition.java
Outdated
Show resolved
Hide resolved
0f3f6d1
to
1a1ec9a
Compare
run tests |
...s/test/scenarios/execution/condition/AbstractQuarkusScenarioContainerExecutionCondition.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think my last review comment will require changes.
afc6616
to
5238f12
Compare
run tests |
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Think this looks fine now, although that catch (Exception ex)
is kinda nasty.
Let's get the CI run green - it seems that the test clusters had full objectstore after last week.
All green, merging, thanks for the review. |
Summary
Tests are automatically disabled when Linux containers are not available, but the test has managing resource that requires Linux containers. Detecting when Quarkus CLI starts in DEV mode will require additional effort.
Please check the relevant options
run tests
phrase in comment)Checklist: