Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use short image names for Kafka Confluent #773

Merged
merged 1 commit into from
May 5, 2023

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented May 5, 2023

Summary

Use short image names for Kafka Confluent as problem was solved in Testcontainers 1.18.0

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk requested a review from fedinskiy May 5, 2023 13:23
// todo https://github.com/testcontainers/testcontainers-java/issues/5612
.asCompatibleSubstituteFor("confluentinc/cp-kafka");
return new KafkaContainer(imageName)
return new KafkaContainer(DockerImageName.parse(getKafkaImage() + ":" + getKafkaVersion()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this solved for podman as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully run tests with podman on my local machine using the configuration from this guide https://quarkus.io/guides/podman#linux

Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fedinskiy fedinskiy merged commit 5db6250 into quarkus-qe:main May 5, 2023
@michalvavrik michalvavrik mentioned this pull request May 16, 2023
11 tasks
@gtroitsk gtroitsk deleted the confluent-kafka-container branch May 30, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants