Skip to content

Commit

Permalink
Use short image names for Kafka Confluent
Browse files Browse the repository at this point in the history
  • Loading branch information
gtroitsk authored and fedinskiy committed May 5, 2023
1 parent d102e9e commit 5db6250
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@ public String getDisplayName() {

@Override
protected GenericContainer<?> initKafkaContainer() {
DockerImageName imageName = DockerImageName
.parse(getKafkaImage() + ":" + getKafkaVersion())
// todo https://github.com/testcontainers/testcontainers-java/issues/5612
.asCompatibleSubstituteFor("confluentinc/cp-kafka");
return new KafkaContainer(imageName)
return new KafkaContainer(DockerImageName.parse(getKafkaImage() + ":" + getKafkaVersion()))
.withCreateContainerCmdModifier(cmd -> cmd.withName(DockerUtils.generateDockerContainerName()));
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.quarkus.test.services.containers.model;

public enum KafkaRegistry {
CONFLUENT("docker.io/confluentinc/cp-schema-registry", "7.3.3", "/", 8081),
CONFLUENT("confluentinc/cp-schema-registry", "7.3.3", "/", 8081),
APICURIO("quay.io/apicurio/apicurio-registry-mem", "2.4.2.Final", "/apis", 8080);

private final String image;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.quarkus.test.services.containers.model;

public enum KafkaVendor {
CONFLUENT("docker.io/confluentinc/cp-kafka", "7.3.3", 9093, KafkaRegistry.CONFLUENT),
CONFLUENT("confluentinc/cp-kafka", "7.3.3", 9093, KafkaRegistry.CONFLUENT),
STRIMZI("quay.io/strimzi/kafka", "0.34.0-kafka-3.4.0", 9092, KafkaRegistry.APICURIO);

private final String image;
Expand Down

0 comments on commit 5db6250

Please sign in to comment.